Potential fix for code scanning alert no. 10: Workflow does not contain permissions#305
Merged
Potential fix for code scanning alert no. 10: Workflow does not contain permissions#305
Conversation
…in permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/18F/analytics-reporter-api/security/code-scanning/10
In general, the fix is to explicitly declare
permissionsfor the workflow so that theGITHUB_TOKENis not using broad repository defaults. Since all visible jobs only need to read the repository (checkout code, install dependencies, run lint/tests, and then call a reusable workflow), we can safely grantcontents: readat the top level. This will apply to all jobs that do not overridepermissions.The best minimal, non‑breaking change is to add a root‑level
permissions:block near the top of.github/workflows/ci.yml, alongsideon:andjobs:. We’ll setpermissions: contents: read, which is sufficient foractions/checkout@v4and typical uses ofGITHUB_TOKENin CI. We won’t touch the jobs themselves or the deploy configuration, preserving existing behavior.Concretely:
.github/workflows/ci.yml.on:section and thejobs:section (after line 4 and before line 5 in the snippet).Suggested fixes powered by Copilot Autofix. Review carefully before merging.