Revert "Temporary fix - Add filters to remove sensitive NSF URLs from public data#1023
Merged
Revert "Temporary fix - Add filters to remove sensitive NSF URLs from public data#1023
Conversation
… public data." This reverts commit c72b777.
sanason
force-pushed
the
remove-nsf-filters
branch
from
ba16b68 to
3b72116
Compare
sanason
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c72b777.
The sensitive data has been redacted in Google Analytics (via a data deletion request) so it is safe to remove the filters that were put in place to block the sensitive data from being exported from GA to the public reports. I did add some
(data deleted)dimension filters to prevent export of the redacted fields - not for security reasons, just to keep the data reported in analytics.usa.gov clean and non-confusing.If you have permission to view draft security advisories in this repo, you can see more details there.