Skip to content

Commit 9c3606b

Browse files
authored
Merge pull request #1398 from 18F/feature/subset_of_the_big_one
[Feature] Add screen resolutions chart
2 parents 5f17784 + eff4b90 commit 9c3606b

File tree

68 files changed

+23019
-2015
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

68 files changed

+23019
-2015
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ jobs:
6565
- lint-js
6666
- lint-styles
6767
- test
68-
if: github.ref == 'refs/heads/develop'
68+
if: github.ref == 'refs/heads/feature/subset_of_the_big_one'
6969
uses: 18F/analytics.usa.gov/.github/workflows/deploy.yml@develop
7070
with:
7171
API_APP_NAME: ${{ vars.API_APP_NAME_DEV }}

_includes/analytics_definitions.html

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -244,9 +244,9 @@ <h3 id="report_realtime_top_pages" class="usa-accordion__heading">
244244
<a href="#dimension_operating_system">operating_system</a>
245245
</li>
246246
<li>
247-
Description: devices, web browsers, and operating systems users
248-
were on when interacting with DAP-participating government
249-
websites in the past 30 days.
247+
Description: devices, web browsers, operating systems, and
248+
screen resolutions that users were on when interacting with
249+
DAP-participating government websites in the past 30 days.
250250
</li>
251251
</ul>
252252
</div>
@@ -646,19 +646,39 @@ <h4 id="dimension_screen_name" class="usa-accordion__heading">
646646
</span>
647647
</div>
648648

649-
<h4 id="dimension_source_medium" class="usa-accordion__heading">
649+
<h4 id="dimension_screen_resolution" class="usa-accordion__heading">
650650
<button
651651
type="button"
652652
class="usa-accordion__button"
653653
aria-expanded="false"
654654
aria-controls="dimensions__section16"
655655
>
656-
Source medium
656+
Screen resolution
657657
</button>
658658
</h4>
659659
<div
660660
id="dimensions__section16"
661661
class="usa-accordion__content usa-prose"
662+
>
663+
<span>
664+
The width and height (in pixels) of the screen from which user
665+
activity originates.
666+
</span>
667+
</div>
668+
669+
<h4 id="dimension_source_medium" class="usa-accordion__heading">
670+
<button
671+
type="button"
672+
class="usa-accordion__button"
673+
aria-expanded="false"
674+
aria-controls="dimensions__section17"
675+
>
676+
Source medium
677+
</button>
678+
</h4>
679+
<div
680+
id="dimensions__section17"
681+
class="usa-accordion__content usa-prose"
662682
>
663683
<span>
664684
A source is a representation of the publisher or inventory

_includes/header.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
<header id="analytics-header" class="grid-row">
1+
<header id="analytics-header" class="grid-row padding-3">
22
<h1>
33
<img
44
src="{{ site.baseurl }}/images/analytics.svg"

0 commit comments

Comments
 (0)