Skip to content

Use the session locale on OIDC requests with no locale param #12024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jmhooper wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use the session locale on OIDC requests with no locale param #12024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bcd347
Use the session locale on OIDC requests with no locale param
jmhooper Mar 25, 2025
8922088
spec failure fix
jmhooper Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/controllers/application_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,14 @@ def store_web_locale_in_session
user_session[:web_locale] = I18n.locale.to_s
end

def override_locale_with_web_locale
return unless user_signed_in?
return if user_session[:web_locale].nil?
return if params[:locale].present?

I18n.locale = LocaleChooser.new(user_session[:web_locale], request).locale
end

def pii_requested_but_locked?
if resolved_authn_context_result.identity_proofing? || resolved_authn_context_result.ialmax?
current_user.identity_verified? &&
Expand Down
1 change: 1 addition & 0 deletions app/controllers/openid_connect/authorization_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ class AuthorizationController < ApplicationController

before_action :build_authorize_form_from_params, only: [:index]
before_action :set_devise_failure_redirect_for_concurrent_session_logout
before_action :override_locale_with_web_locale
before_action :pre_validate_authorize_form, only: [:index]
before_action :sign_out_if_prompt_param_is_login_and_user_is_signed_in, only: [:index]
before_action :store_request, only: [:index]
Expand Down