[LG-16274] Limit character length on user supplied names for auth_app_configuration, piv_cac_configuration, and webauthn_configuration

app/models/auth_app_configuration.rb

@@ -7,7 +7,7 @@ class AuthAppConfiguration < ApplicationRecord
 
   belongs_to :user
 
-  validates :name, presence: true
+  validates :name, presence: true, length: { maximum: 20 }
 
   def mfa_enabled?
     otp_secret_key.present?

app/models/piv_cac_configuration.rb

@@ -2,8 +2,7 @@
 
 class PivCacConfiguration < ApplicationRecord
   belongs_to :user
-
-  validates :name, presence: true
+  validates :name, presence: true, length: { maximum: 20 }
 
   def mfa_enabled?
     x509_dn_uuid.present?

app/models/webauthn_configuration.rb

@@ -2,7 +2,7 @@
 
 class WebauthnConfiguration < ApplicationRecord
   belongs_to :user
-  validates :name, presence: true
+  validates :name, presence: true, length: { maximum: 80 }
   validates :credential_id, presence: true
   validates :credential_public_key, presence: true
   validate :valid_transports

spec/controllers/users/totp_setup_controller_spec.rb

@@ -82,7 +82,7 @@
   end
 
   describe '#confirm' do
-    let(:name) { SecureRandom.hex }
+    let(:name) { SecureRandom.hex[0, 15] }
     let(:success) { false }
 
     before do

spec/factories/auth_app_configurations.rb

@@ -2,7 +2,7 @@
   Faker::Config.locale = :en
 
   factory :auth_app_configuration do
-    name { Faker::Lorem.unique.words.join(' ') }
+    name { Faker::Lorem.unique.words.join(' ')[0, 19] }
     otp_secret_key { SecureRandom.hex(16) }
     user
   end

spec/factories/piv_cac_configurations.rb

@@ -2,7 +2,7 @@
   Faker::Config.locale = :en
 
   factory :piv_cac_configuration do
-    name { Faker::Lorem.unique.words.join(' ') }
+    name { Faker::Lorem.unique.words.join(' ')[0, 19] }
     x509_dn_uuid { Random.uuid }
     user
   end

spec/forms/totp_setup_form_spec.rb

@@ -4,7 +4,7 @@
   let(:user) { create(:user) }
   let(:secret) { user.generate_totp_secret }
   let(:code) { generate_totp_code(secret) }
-  let(:name) { SecureRandom.hex }
+  let(:name) { SecureRandom.hex[0, 19] }
 
   describe '#submit' do
     context 'when TOTP code is valid' do

spec/models/auth_app_configuration_spec.rb

@@ -0,0 +1,25 @@
+require 'rails_helper'
+
+RSpec.describe AuthAppConfiguration do
+  describe 'Associations' do
+    it { is_expected.to belong_to(:user) }
+  end
+
+  describe 'name validations' do
+    it 'is invalid when name is longer than 20 characters' do
+      config = AuthAppConfiguration.new(
+        name: 'a' * 21,
+      )
+
+      expect(config).not_to be_valid
+    end
+
+    it('is valid when name has exactly 20 characters') do
+      config = AuthAppConfiguration.new(
+        name: 'a' * 20,
+      )
+
+      expect(config).to be_valid
+    end
+  end
+end

spec/models/piv_cac_configuration_spec.rb

@@ -0,0 +1,25 @@
+require 'rails_helper'
+
+RSpec.describe PivCacConfiguration do
+  describe 'Associations' do
+    it { is_expected.to belong_to(:user) }
+  end
+
+  describe 'name validations' do
+    it 'is invalid when name is longer than 20 characters' do
+      config = PivCacConfiguration.new(
+        name: 'a' * 21,
+      )
+
+      expect(config).not_to be_valid
+    end
+
+    it('is valid when name has exactly 20 characters') do
+      config = PivCacConfiguration.new(
+        name: 'a' * 20,
+      )
+
+      expect(config).to be_valid
+    end
+  end
+end

spec/models/webauthn_configuration_spec.rb

@@ -106,4 +106,24 @@
       it { expect(subject).not_to be_valid }
     end
   end
+
+  describe 'name validations' do
+    it 'is invalid when name is longer than 80 characters' do
+      config = WebauthnConfiguration.new(
+        name: 'a' * 81, credential_id: '111',
+        credential_public_key: '222'
+      )
+
+      expect(config).not_to be_valid
+    end
+
+    it('is valid when name has exactly 80 characters') do
+      config = WebauthnConfiguration.new(
+        name: 'a' * 80, credential_id: '111',
+        credential_public_key: '222'
+      )
+
+      expect(config).to be_valid
+    end
+  end
 end