Skip to content

fix: Fix the upgrade service file location issue #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 1 commit into from
Nov 28, 2025
Merged

fix: Fix the upgrade service file location issue #11109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/app/service/upgrade.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
return notes, nil
}

func (u *UpgradeService) Upgrade(req dto.Upgrade) error {

Check failure on line 107 in core/app/service/upgrade.go

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 28 to the 15 allowed. 


See more on https://sonarcloud.io/project/issues?id=1Panel-dev_1Panel&issues=AZrIRaCrrdyHc4pE_P1u&open=AZrIRaCrrdyHc4pE_P1u&pullRequest=11109
global.LOG.Info("start to upgrade now...")
baseDir := path.Join(global.CONF.Base.InstallDir, fmt.Sprintf("1panel/tmp/upgrade/%s", req.Version))
downloadDir := path.Join(baseDir, "downloads")
Expand Down Expand Up @@ -187,13 +187,13 @@
}
initScriptPath := path.Join(tmpDir, "initscript")

if err := files.CopyItem(false, true, path.Join(initScriptPath, selCoreName), path.Join(svcCoreName, scriptCoreName)); err != nil {
if err := files.CopyItem(false, true, path.Join(initScriptPath, selCoreName), svcBasePath); err != nil {
global.LOG.Errorf("upgrade %s failed, err: %v", svcCoreName, err)
_ = settingRepo.Update("SystemStatus", "Free")
u.handleRollback(originalDir, 3)
return
}
if err := files.CopyItem(false, true, path.Join(initScriptPath, selAgentName), path.Join(svcAgentName, scriptAgentName)); err != nil {
if err := files.CopyItem(false, true, path.Join(initScriptPath, selAgentName), svcBasePath); err != nil {
global.LOG.Errorf("upgrade %s failed, err: %v", svcAgentName, err)
_ = settingRepo.Update("SystemStatus", "Free")
u.handleRollback(originalDir, 3)
Expand Down
Loading