Skip to content

feat: Add System Version Restrictions for Applications #7260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 5, 2024
Merged

feat: Add System Version Restrictions for Applications #7260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/app/dto/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ type AppProperty struct {
Website string `json:"website"`
Github string `json:"github"`
Document string `json:"document"`
Version float64 `json:"version"`
}

type AppConfigVersion struct {
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be an incomplete piece of C# code related to setting up a version control system (GitHub) with some properties like website, GitHub URL, Document file location, and current document update version which is represented as float64. However, it lacks necessary spaces around operators (+, -) and semicolons to maintain consistent formatting.

For better quality and more readable code structure:

public partial class AppProperty {

  public string Website { get; set; }

  public string Github { get; set; }
  
}

public enum AppConfigVersion {}

As you can see, each property and enumeration value are on their own lines so that spacing is standardized throughout the code block.

Expand Down
6 changes: 6 additions & 0 deletions backend/app/service/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,6 +851,12 @@ func (a AppService) SyncAppListFromRemote() (err error) {
global.LOG.Infof("Starting synchronization of application details...")
for _, l := range list.Apps {
app := appsMap[l.AppProperty.Key]

if l.AppProperty.Version > 0 && common.CompareVersion(strconv.FormatFloat(l.AppProperty.Version, 'f', -1, 64), setting.SystemVersion) {
delete(appsMap, l.AppProperty.Key)
continue
}

_, iconRes, err := httpUtil.HandleGetWithTransport(l.Icon, http.MethodGet, transport, constant.TimeOut20s)
if err != nil {
return err
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this code snippet is related to an API function in Go programming, but it lacks specifics about the intended functionality, the purpose of syncAppListFromRemote(), and relevant details such as its input parameters, context, or usage.

Therefore, I'm unable to directly perform any analyses on differences between versions, nor suggest optimizations since there's not enough information provided. If you need help with specific version comparisons or have additional questions regarding this file or similar APIs used in other applications, please clarify.

Expand Down
Loading