Skip to content

Conversation

@wan92hen
Copy link
Contributor

@wan92hen wan92hen commented Dec 6, 2024

What this PR does / why we need it?

Refine some English text.

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 6, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zhengkunwang223 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wanghe-fit2cloud wanghe-fit2cloud merged commit b88438a into 1Panel-dev:dev Dec 6, 2024
1 of 4 checks passed
key: 'Key',
check: 'View',
acmeAccountManage: 'View ACME accounts',
acmeAccountManage: 'ACME accounts',
Copy link
Member

@JohnNiang JohnNiang Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest preserving View prefix for the button text.

See https://developers.google.com/workspace/add-ons/guides/editor-style#buttons for more.

deploySSLHelper: 'Are you sure to deploy the certificate? ',
ssl: 'Certificate',
dnsAccountManage: 'View DNS provider accounts',
dnsAccountManage: 'DNS providers',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

applyStart: 'Certificate application starts',
getDnsResolve: 'Getting DNS resolution value, please wait...',
selfSigned: 'View Self-signed certificates',
selfSigned: 'Self-signed certificates',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants