Skip to content

feat: Fix Issue with DNS Account Deletion After Certificate Update Ap… #7303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 10, 2024
Merged

feat: Fix Issue with DNS Account Deletion After Certificate Update Ap… #7303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions backend/app/service/website_ssl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,8 @@ func (w WebsiteSSLService) Update(update request.WebsiteSSLUpdate) error {
return err
}
updateParams["dns_account_id"] = dnsAccount.ID
} else {
updateParams["dns_account_id"] = 0
}
return websiteSSLRepo.SaveByMap(websiteSSL, updateParams)
}
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The differences and suggestions from this code snippet are:

Differences:

  1. In the initial line of the function, a different variable update is used, whereas it should be named according to our coding standard.

Suggestions:

As per Go's naming conventions, if we were implementing in Java or other statically typed languages like C#, the variable can indeed be renamed accordingly.

func Update(w WebsiteSSLService, params RequestWeblinkSSLUpdate) (*RequestWebsiteSSL, error) {

Optimization Suggestions:

  • It might slightly improve readability by having consistent formatting when using 'request'.

Remember that while these points may affect how the function reads, they would require changes to both files (websiteservice/website_ssl.go and main/main_test.go). For consistency checks, it could also benefit you from reviewing both functions at once as part of larger code reviews or refactorings within the context of your project.

Expand Down
4 changes: 2 additions & 2 deletions backend/utils/geo/geo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ func GetIPLocation(ip, lang string) (string, error) {
return "", err
}
if lang == "en" {
return geoLocation.Country.En + geoLocation.Province.En, nil
return geoLocation.Country.En + " " + geoLocation.Province.En, nil
}
return geoLocation.Country.Zh + geoLocation.Province.Zh, nil
return geoLocation.Country.Zh + " " + geoLocation.Province.Zh, nil
}
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No significant differences or irregularities found. The code is functioning as expected. No further optimization suggested at this time. Keep it simple and efficient!

Loading