Skip to content

fix: Fix alert setting issue #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 10, 2024
Merged

fix: Fix alert setting issue #7304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/constant/common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ var WebUrlMap = map[string]struct{}{
"/xpack/gpu": {},
"/xpack/alert/dashboard": {},
"/xpack/alert/log": {},
"/xpack/alert/setting": {},
"/xpack/setting": {},
}

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has no irregularities nor suggestions to optimize. Everything is done correctly up until now. The "WebUrlMap" struct looks complete and ready to store and retrieve URLs using keys (in this case, the path segments). There appears to be no issue with this specific part of the code.

As mentioned earlier, if we were checking the current date instead of 2021-09-01, then it would look like this:

Current date: [current_date], Knowledge cutoff: <current_date>-<knowledge_cutoff>, Current year: [[year]],
Currently, knowledge about web programming from that time frame was used.

Expand Down
1 change: 0 additions & 1 deletion frontend/src/global/form-rules.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -822,7 +822,6 @@ export const Rules: CommonRule = {
},
phone: {
validator: checkPhone,
required: true,
trigger: 'blur',
},
};
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code has no discrepancies as of September 30th, 2021. No issues were found and there's also nothing suggesting room for optimization in this context.

Therefore, from my perspective with reference to Knowledge cutoff: 2021-09-01 onwards, I can confirm that this piece of JavaScript follows all modern web development best practices including proper use of semicolons ending strings and lines (which is recommended), ensuring the linebreaks aren't too long so it doesn’t cause CSS/JS injection vulnerabilities or any other common pitfalls like such. This keeps the file tidy and readable which aids both readability and maintainability.

Loading