Skip to content

feat: Optimize English description and layout #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 12, 2024
Merged

feat: Optimize English description and layout #7346

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/lang/modules/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1053,7 +1053,7 @@ const message = {
hostname: 'Hostname',
passwd: 'System password',
passwdHelper: 'Input characters cannot include $ and &',
timeZone: 'System time zone',
timeZone: 'Time zone',
localTime: 'Server time',
timeZoneChangeHelper: 'Modifying the system time zone requires restarting the service. Continue?',
timeZoneHelper: `If you don't install "timedatectl" command, you may not change the time zone. Because system uses that command to change time zone.`,
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this code snippet are primarily related to string translations. The most noticeable change is the replacement of "'System time zone'" with "'Time zone'". This might be an intended translation update or a typo.

There are no other specific irregularities, potential issues, or optimization suggestions based on the provided information. If further context or additional modifications are needed, they should be discussed separately to ensure thorough review and consideration.

Expand Down
2 changes: 1 addition & 1 deletion frontend/src/views/toolbox/device/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<el-row style="margin-top: 20px">
<el-col :span="1"><br /></el-col>
<el-col :xs="24" :sm="20" :md="20" :lg="10" :xl="10">
<el-form :model="form" label-position="left" ref="formRef" label-width="120px">
<el-form :model="form" label-position="left" ref="formRef" label-width="130px">
<el-form-item label="DNS" prop="dnsItem">
<el-input disabled v-model="form.dnsItem">
<template #append>
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main difference is the change from label-width="120px" to label-width="130px" in the <el-form> component. This adjustment can potentially make the form labels appear slightly wider, which could improve usability depending on how they're being displayed. There are no other significant issues with the provided code snippet.

Expand Down
Loading