Skip to content

feat: Language pack content adjustment #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 12, 2024
Merged

feat: Language pack content adjustment #7349

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/lang/modules/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,11 @@ const message = {
title: 'Linux Server Management Panel',
licenseHelper:
'Agree &laquo; <a href="https://www.fit2cloud.com/legal/licenses.html" target="_blank">Community License Agreement</a> &raquo;',
errorAgree: 'Please click to agree to the Community Software License Agreement',
errorAgree: 'Click to agree to the Community Software License',
logout: 'Logout',
agreeTitle: 'Agreement',
agreeContent:
'In order to better protect your legitimate rights and interests, please read and agree to the following agreement &laquo; <a href = "https://www.fit2cloud.com/legal/licenses.html" target = "_blank" > fly to cloud community software license agreement </a> &raquo;',
'In order to better protect your legitimate rights and interests, please read and agree to the following agreement &laquo; <a href = "https://www.fit2cloud.com/legal/licenses.html" target = "_blank" > Community License Agreement </a> &raquo;',
},
rule: {
username: 'Enter a username',
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippets do not contain any immediate discrepancies or major issues that need correction. The changes made from version 173 to 173 (which appears to be redundant) appear minor but could potentially reduce redundancy slightly if further adjustments were desired.

Here are some potential optimizations, although they may not impact performance significantly at this scale:

  1. Consistent Link Text:

    • Both the old link text mentions "Comunity License Agreement" which should ideally match consistently throughout all instances where such links are used.

    Suggested change:

    agreeTitle: 'Agreement',
agreeContent: 'In order to better protect your legitimate rights and interests, please read and agree to the following agreement &laquo; <a href="https://www.fit2cloud.com/legal/licenses.html" target="_blank">Community License Agreement</a> &raquo;',

  2. Refactor Error Message:

    • If possible, refactor error messages to follow a consistent format. This consistency can improve readability and maintainability.

    Example:

    errorAgree: 'Please click here to accept the Community Software License Agreement.',

    And correspondingly update agreeContent accordingly when necessary.

These refinements would make the code cleaner and more predictable across different sections. However, these updates should primarily focus on improving readability rather than optimizing efficiency in terms of runtime performance.

Expand Down
Loading