Skip to content

Conversation

@JohnNiang
Copy link
Member

@JohnNiang JohnNiang commented Dec 18, 2024

What this PR does / why we need it?

This PR refines English translation and UI style of home page.

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.
None

Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm label Dec 18, 2024
@wanghe-fit2cloud wanghe-fit2cloud merged commit c522a30 into 1Panel-dev:dev Dec 18, 2024
1 of 4 checks passed
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wanghe-fit2cloud

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang deleted the chore/refine-en-translation branch December 18, 2024 02:24
@JohnNiang JohnNiang mentioned this pull request Jun 10, 2025
3 tasks
wanghe-fit2cloud pushed a commit that referenced this pull request Jun 11, 2025
* Refine English translation (#7232)

* Refine English translation  (#7247)

* Refine pluralization of some English words (#7318)

* Refine plural translation of English words

* Remove useless i18n modifier

* Refine English translation again and again (#7353)

* Replace whitelist and blacklist with allowlist and blocklist (#7358)

* Refine English translation and UI style (#7399)

* Resolve build error

* Fix build error
@JohnNiang JohnNiang mentioned this pull request Jun 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants