Skip to content

style: Optimize style #7414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Dec 18, 2024
Merged

style: Optimize style #7414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/styles/element-dark.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ html.dark {
--panel-terminal-tag-active-text-color: var(--panel-color-primary);
--panel-terminal-tag-hover-text-color: var(--panel-color-primary);
--panel-logs-bg-color: var(--panel-main-bg-color-9);
--panel-alert-bg-color: var(--panel-main-bg-color-10);

--el-menu-item-bg-color: var(--panel-main-bg-color-10);
--el-menu-item-bg-color-active: var(--panel-main-bg-color-8);
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No irregularities were found in the provided code changes. The addition of --panel-alert-bg-color suggests that alerts may include custom styling with this background color, enhancing user experience based on its usage within your application.

Expand Down
1 change: 1 addition & 0 deletions frontend/src/styles/element.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ html {
--panel-terminal-tag-hover-text-color: #575758;
--panel-terminal-bg-color: #1e1e1e;
--panel-logs-bg-color: #1e1e1e;
--panel-alert-bg-color: rgba(0, 94, 235, 0.03);;

--panel-alert-bg: #e2e4ec;
--panel-path-bg: #ffffff;
Expand Down
5 changes: 0 additions & 5 deletions frontend/src/views/container/image/pull/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,3 @@ defineExpose({
acceptParams,
});
</script>
<style scoped>
:deep(.log-container) {
background-color: var(--panel-main-bg-color-10);
}
</style>
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No significant issues were found in the provided code snippet. The defineExpose function is defined correctly within the Vue component script section of the template. There are no unused CSS classes or styles that need to be removed.

2 changes: 1 addition & 1 deletion frontend/src/views/setting/snapshot/status/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ defineExpose({
border-top: 1px var(--el-border-color) var(--el-border-style);
}
.alert {
background-color: var(--panel-main-bg-color-10);
background-color: var(--panel-alert-bg-color);
}

.card-title {
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look generally correct. Here's a brief review:

  1. --panel-main-bg-color-10 to --panel-alert-bg-color: This is fine as it appears consistent throughout similar styles.

  2. The styling of .card-title looks mostly standard and should work properly.

There might be other styles or components that could benefit from further review if you provide more details about the complete context or additional files involved in this project. Otherwise, this set of changes seems appropriate given the existing style variables (var(--panel-main-bg-color-10) for alerts).

Expand Down
Loading