-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(appstore): Optimize Custom Application Logic #7603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| fileOp := files.NewFileOp() | ||
| for _, dir := range dirs { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no obvious errors or improvements in this Go code.
@@
| config.tail = tail; | ||
| } | ||
| open.value = true; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the above code for any irregularity/suggested modifications. The current context is limited to before September 1st, 2021. Additionally, please note that I am not able to execute JavaScript or check its functionality directly within this platform.
|
|
||
| func (a AppRepo) WithArch(arch string) DBOption { | ||
| return func(g *gorm.DB) *gorm.DB { | ||
| return g.Where("architectures like ?", fmt.Sprintf("%%%s%%", arch)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no significant differences between the two versions of the code. The implementation remains consistent and does not require any changes to achieve the desired functionality.
|
wanghe-fit2cloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |




No description provided.