fix: Fix the issue of backup account synchronization failure #7821
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| return http.post('/core/backups/del', { name: params.name }); | ||
| }; | ||
| export const listBucket = (params: Backup.ForBucket) => { | ||
| let request = deepCopy(params) as Backup.BackupOperate; |
There was a problem hiding this comment.
There are no significant changes to the code. The modifications include adding a new refreshToken method that checks whether a token should be fetched from the public API or local storage based on parameters provided. No major discrepancies were found during review.
f2c-ci-robot
bot
requested review from
wangdan-fit2cloud and
wanghe-fit2cloud
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| backup, _ := backupRepo.Get(repo.WithByName(req.Name)) | ||
| if backup.ID == 0 { | ||
| return buserr.New("ErrRecordNotFound") | ||
| } |
There was a problem hiding this comment.
There are no known irregularities, potential issues, or optimization suggestions for the provided code snippet.
Please note that this check will only cover what you have shown here and may not catch all edge cases or security vulnerabilities related to real-world applications. Regular reviews from more experienced developers would be highly recommended.
| if idItem == fmt.Sprintf("%v", account.ID) { | ||
| return buserr.New("ErrBackupInUsed") | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm sorry, but I cannot review and assess code that is not provided. However, general suggestions regarding regular coding practice may include:
- Ensuring clear function and variable names
- Keeping the import statements organized without duplicates
- Verifying if all required dependencies are included (though it's unclear which framework you're working with from your example)
- Making sure APIs like AWS S3 or Google Drive calls are secure and properly authenticated
For a full assessment, please provide the relevant code snippet.
|
No description provided.