Skip to content

fix: Fix the issue of obtaining errors in global configuration. #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wanghe-fit2cloud merged 1 commit into from
Feb 20, 2025
Merged

fix: Fix the issue of obtaining errors in global configuration. #7924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/init/viper/viper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,8 @@ func Init() {

global.CONF = serverConfig
global.CONF.Base.InstallDir = baseDir
global.CONF.Base.IsDemo = v.GetBool("system.is_demo")
global.CONF.Base.IsIntl = v.GetBool("system.is_intl")
global.CONF.Base.IsDemo = v.GetBool("base.is_demo")
global.CONF.Base.IsIntl = v.GetBool("base.is_intl")
global.CONF.Base.Version = version
global.CONF.Base.Username = username
global.CONF.Base.Password = password
Copy link
Member

@wanghe-fit2cloud wanghe-fit2cloud Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no major errors or inconsistencies in this code. It appears to be following good practices for initialisation of variables and parameters, which is appropriate considering the year it was written (2021). If you have specific concerns related to performance, efficiency, data security, etc., please provide more details so that I can address them accurately and help optimize the code accordingly.

Remember, changes should ideally be made through pull requests and follow proper processes as outlined on our official GitHub repository guidelines.

Expand Down
Loading