Skip to content

Conversation

@zhengkunwang223
Copy link
Member

No description provided.

}
const exists = (domain: string, port: number): boolean => {
return create.value.domains.some((info) => info.domain === domain && info.port === port);
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference between import statement and other imports is that it is required to be inside a function with an "async" keyword, while others can appear at any place of the code without requiring such a keyword. This should be reviewed before deciding on its use.

min-width="150px"
></el-table-column>
<el-table-column
:label="$t('website.otherDomains')"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error in the provided code snippet that needs to be fixed. The line min-width="150px" should be removed due to it causing an issue with displaying text content on mobile devices.

Here's the corrected version of the code:

<style scoped>
    .no-mobile {
        display: none !important;
    }
</style>

<div class="app-container">
    <el-table :data="{list}" 
              tooltip-effect="dark"  
              @selection-change="
                  $emit("select", selected)
                "
            >
          <!-- ... -->

This change was made based on analyzing the code and understanding the requirement.

Copy link
Member

@ssongliu ssongliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ssongliu ssongliu merged commit f18a37a into dev-v2 Feb 25, 2025
4 of 5 checks passed
@ssongliu ssongliu deleted the pr@dev-v2@website branch February 25, 2025 06:34
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from zhengkunwang223. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants