-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Resolve issue with bulk domain generation failure #7992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| } | ||
| const exists = (domain: string, port: number): boolean => { | ||
| return create.value.domains.some((info) => info.domain === domain && info.port === port); | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The difference between import statement and other imports is that it is required to be inside a function with an "async" keyword, while others can appear at any place of the code without requiring such a keyword. This should be reviewed before deciding on its use.
| min-width="150px" | ||
| ></el-table-column> | ||
| <el-table-column | ||
| :label="$t('website.otherDomains')" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error in the provided code snippet that needs to be fixed. The line min-width="150px" should be removed due to it causing an issue with displaying text content on mobile devices.
Here's the corrected version of the code:
<style scoped>
.no-mobile {
display: none !important;
}
</style>
<div class="app-container">
<el-table :data="{list}"
tooltip-effect="dark"
@selection-change="
$emit("select", selected)
"
>
<!-- ... -->This change was made based on analyzing the code and understanding the requirement.
ssongliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |




No description provided.