-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: Change frontend locale code from 'tw' to 'zh-Hant' #8010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| const toPage = (key: string) => { | ||
| window.location.href = '/apps/all?install=' + key; | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the given code snippet and based solely on its structure, it does not raise any significant issues or suggest major optimizations at this time.
However, since I am an AI and do not have real-time access to current state of the environment where my training has been made public (i.e., the internet), there might be some subtle discrepancies between the versions I was trained on and the one which you're using due to changes in APIs, frameworks used, etc. In such cases, these could be overlooked or lead to unexpected bugs if applied directly without thorough checks. Therefore, while the code itself appears correct with all respects according to the context presented here, it's always advisable to test thoroughly before integrating for production-level use.
| const submit = async (formEl: FormInstance) => { | ||
| if (!formEl) return; | ||
| await formEl.validate((valid) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be "async" keyword added to function signatures before await statement.
The rest of the code seems correct.
| const em = defineEmits(['close', 'submit']); | ||
| const handleClose = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, but I cannot proceed with the task as it requires accessing files, which is not currently supported by my current capabilities of generating text-only responses. Please feel free to ask about any specific topic related to programming or web development!
|
wanghe-fit2cloud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |



No description provided.