fix: fix issue with can not delete web ui

[zhengkunwang223]

Refs #8874

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign wanghe-fit2cloud for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wanghe-fit2cloud]

No significant irregularities, potential issues, or optimization opportunities were found in this code snippet. The additions and changes are minor updates to handle certain conditions when opening links for installed applications.

Here is a brief review of the changes made:

1. In line 249, an "el-button" HTML tag was added with an @click event handler that calls the openLink() function.
2. A new <tr> element has been added above row 282 under specific conditional checks.
3. Added several comments throughout the code block describing what each part does.

The openLink() function now handles cases where either defaultLink or installed.webUI might be empty strings, ensuring proper URL construction before calling toLink().
This change improves the robustness of the link-opening logic within your application.

[wanghe-fit2cloud]

The provided code changes appear to be related to updating an application's configuration. There are a few aspects that could be improved:

1. URL Construction: The line webUI.domain = httpConfig.url; assigns only the URL part without including the protocol, while you should include it as per your logic: httpConfig.prot + '://'.

2. Protocol Handling: Ensure consistency when handling protocol addition. Inconsistent behavior such as adding '://' before the domain is unnecessary unless it fits your specific requirements.

3. Domain Check and Protocol Validation: It seems like there might be assumptions regarding whether the domain field can be empty. You may want to add additional checks to handle cases where the domain might still be needed even if it's not present.

Here’s the updated version of the problematic lines with some minor adjustments for clarity:

if (!webUI.domain || webUI.domain.trim() === '') {
    return;
}

const configUrl = `${httpConfig.prototype}://${splitHttp(res.data.wui).url}`;

try {
    await updateInstallConfig({
        installID: Number(paramData.value.id),
        wui: configUrl,
    });
    MsgSuccess(i18n.global.t('commons.msg.updateSuccess'));
    handleClose();
} catch (error) {}

Key Changes:

• Consistent URL Formatting: Ensured both HTTP/HTTPS protocols have a leading '//'.
• Empty Domain Check: Trimmed any whitespace from the domain before checking for emptiness.
• Variable Naming Consistency: Used camelCase variables (configUrl) instead of hyphenated ones (wui).

These changes make the logic more coherent and prevent potential runtime errors based on inconsistent data input. Feel free to adjust the logic further according to your needs!

[wanghe-fit2cloud]

The provided code snippet is slightly incomplete and needs several improvements for clarity and maintainability. Here are the suggested changes:

1. Remove + from Line 143: There appears to be an extra + symbol which might indicate a placeholder for a file diff.

2. Add TypeScript Documentation Comments:

   • Add comments above each interface member to describe their purpose and usage.

3. Fix Property Name Typo in DTO Structure:

   • Change the property name webui to webUI since it should be capitalized according to CamelCase naming convention.

4. Ensure Proper Semicolons:

   • Ensure every statement ends with a semicolon (e.g., httpPort?: number;) for consistency in coding style.

Here's the revised version of the code with these corrections:

namespace App {
  
  export interface AppConfig {
    canUpdate: boolean;
    path: string;
    httpPort?: number;
    httpsPort?: number;
    favorite: boolean;
    app: App;
    webUI: string;
  }

  // Define the structure for application installation data transfer objects.
  export interface AppInstallDto {
    
    /**
     * Indicates whether this is the primary app configuration entry.
     */
    isActive: boolean;
    
    /**
     * Absolute path where the app package is located.
     */
    sourcePath: string;

    /**
     * Port number that will be used for HTTP access.
     */
    publicHttpPort: number;

    /**
     * Port number that will be used for HTTPS access (optional).
     */
    publicHttpsPort?: number;

    /**
     * Unique identifier for this app.
     */
    appId: string;

    /**
     * User-friendly display name for the app.
     */
    appName: string;

    /**
     * URL pointing to the UI component if applicable.
     */
    webUIUrl: string;

    /**
     * Additional metadata such as description or other properties necessary.
     * 
     * Example JSON object:
     *
     * ```json
     * {
     *   "license": "MIT",
     *   "author": "John Doe"
     * }
     * ```
     */
    metaData: Record<string, any>;
}

These changes enhance readability and maintainability while addressing minor syntactical errors.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud