feat: change 1panel v1 docs url #8993
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| docsUrl: (state) => (state.isIntl ? 'https://docs.1panel.pro' : 'https://1panel.cn/docs/v1'), | ||
| }, | ||
| actions: { | ||
| setOpenMenuTabs(openMenuTabs: boolean) { |
There was a problem hiding this comment.
There appears to be an issue with modifying the docsUrl getter function in your Vuex store. Currently, it's returning different URLs based on whether state.isIntl is true or false, but this does not account for the version change from v1 to v2.
Suggested Changes:
@@ -49,7 +49,7 @@ const GlobalStore = defineStore({
state.themeConfig.theme === 'dark' ||
(state.themeConfig.theme === 'auto' && window.matchMedia('(prefers-color-scheme: dark)').matches),
isDarkGoldTheme: (state) => state.themeConfig.primary === '#F0BE96' && state.isProductPro,
- docsUrl: (state) => (state.isIntl ? 'https://docs.1panel.pro' : 'https://1panel.cn/docs'),
+ docsUrl: (state) => (state.isIntl ? 'https://docs.1panel.pro' : `https://1panel.cn/docs/v${parseInt(state.versionNumber[1])}`), // Assuming state.versionNumber contains a string representation of the current version
},Explanation:
The new suggestion assumes that there is a property called versionNumber within your state which represents the current application version number as a dotted decimal string ("vX.Y"). This allows you to dynamically construct the documentation URL depending on the specific version being used instead of always returning the same fixed URL.
Replace "v1" in the example with 'v' + parseInt(state.versionNumber[1]), assuming state.versionNumber looks like ["", "1"]. The first element of versionNumber will be empty by default when versionNumber is undefined or null, avoiding any potential errors with indexing. Make sure to adjust this logic if your implementation structure differs from what I have described here.
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wanghe-fit2cloud The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.