Skip to content

feat: contract operation#460

Merged
fit2-zhao merged 1 commit intomainfrom
pr@main@feat_contract_operation
Nov 25, 2025
Merged

feat: contract operation#460
fit2-zhao merged 1 commit intomainfrom
pr@main@feat_contract_operation

Conversation

@fit2-zhao
Copy link
Member

feat: contract operation

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 25, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 0% with 80 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@c5f830d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...n/cordys/crm/contract/service/ContractService.java 0.00% 70 Missing ⚠️
...ys/crm/contract/controller/ContractController.java 0.00% 10 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #460   +/-   ##
=======================================
  Coverage        ?   37.86%           
  Complexity      ?     2061           
=======================================
  Files           ?      414           
  Lines           ?    20629           
  Branches        ?     2200           
=======================================
  Hits            ?     7811           
  Misses          ?    12217           
  Partials        ?      601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

LambdaQueryWrapper<ContractSnapshot> wrapper = new LambdaQueryWrapper<>();
wrapper.eq(ContractSnapshot::getContractId, id);
ContractSnapshot snapshot = snapshotBaseMapper.selectListByLambda(wrapper).stream().findFirst().orElse(null);
if (snapshot != null) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot.getContractValue() 是否需要验证?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

保存会有系统必填字段value,倒是不会为空

@fit2-zhao fit2-zhao merged commit 92decd7 into main Nov 25, 2025
10 of 11 checks passed
@fit2-zhao fit2-zhao deleted the pr@main@feat_contract_operation branch November 25, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants