Skip to content

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Variable splitting node expression not validated

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 22, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prop="expression"
>
<el-input
v-model="form.expression"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the given code snippet, there is one main issue to be addressed:

  1. The label property should match the prop used. Here's how you can correct it:

    +      :label="$t('views.applicationWorkflow.nodes.variableSplittingNode.expression.label')"
    

    Modify it to:

    -      :required="true"
  •  :prop="expression"
    
     >
    
    
    

This change ensures that the corresponding rule (rules.label) will correctly validate the input against the label property on the form state when submitted.

No other major issues were found in this specific code snippet.

@shaohuzhang1 shaohuzhang1 merged commit 9faebd8 into v2 Oct 22, 2025
4 of 5 checks passed
@shaohuzhang1 shaohuzhang1 deleted the pr@v2@fix_workflow branch October 22, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants