Skip to content

fix: Variable splitting node expression not validated #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Oct 22, 2025
Merged

fix: Variable splitting node expression not validated #4233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ui/src/workflow/nodes/variable-splitting/component/VariableFieldDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@
<el-form-item
:label="$t('views.applicationWorkflow.nodes.variableSplittingNode.expression.label')"
:required="true"
prop="label"
:rules="rules.label"
prop="expression"
>
<el-input
v-model="form.expression"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the given code snippet, there is one main issue to be addressed:

  1. The label property should match the prop used. Here's how you can correct it:

    +      :label="$t('views.applicationWorkflow.nodes.variableSplittingNode.expression.label')"

    Modify it to:

    -      :required="true"
  •  :prop="expression"

 >

This change ensures that the corresponding rule (rules.label) will correctly validate the input against the label property on the form state when submitted.

No other major issues were found in this specific code snippet.

Expand Down
Loading