fix: Compatibility issues with zooming in and out of AI dialog box images #4495
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if (target.classList && target.classList.contains('medium-zoom-image--opened')) { | ||
| event.preventDefault() | ||
| event.stopPropagation() | ||
There was a problem hiding this comment.
The proposed changes to the code are valid and do not introduce any bugs. However:
- Using
classListis more modern and idiomatic than checking withclassName, which can be deprecated in future versions of JavaScript.
However, if you want to maintain backward compatibility (which isn't strictly necessary given this is new functionality), both styles work fine here.
To answer your main question directly from the provided context: No irregularities or issues were identified but there's an update to use .classList instead of .className.
fix: Compatibility issues with zooming in and out of AI dialog box images