Skip to content

fix: Compatibility issues with zooming in and out of AI dialog box images #4495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 11, 2025
Merged

fix: Compatibility issues with zooming in and out of AI dialog box images #4495

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/components/ai-chat/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -717,11 +717,11 @@ onMounted(() => {
if (event.target) {
const target = event.target as HTMLElement
// 假设打开状态的图片具有特定类名
if (target.className && target.className.includes('medium-zoom-overlay')) {
if (target.classList && target.classList.contains('medium-zoom-overlay')) {
event.preventDefault()
event.stopPropagation()
}
if (target.className && target.className.includes('medium-zoom-image--opened')) {
if (target.classList && target.classList.contains('medium-zoom-image--opened')) {
event.preventDefault()
event.stopPropagation()

Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes to the code are valid and do not introduce any bugs. However:

  1. Using classList is more modern and idiomatic than checking with className, which can be deprecated in future versions of JavaScript.

However, if you want to maintain backward compatibility (which isn't strictly necessary given this is new functionality), both styles work fine here.

To answer your main question directly from the provided context: No irregularities or issues were identified but there's an update to use .classList instead of .className.

Expand Down
Loading