fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters #4498
Conversation
… upload files after adding them in lowercase letters
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| return file_type_list.value.join('、') | ||
| }) | ||
| const file_size_limit = computed(() => { | ||
| return attrs.file_size_limit || 50 |
There was a problem hiding this comment.
There are no obvious errors or optimizations in this code snippet. However, there is a potential issue with the formats calculation: if file_type_list does not contain any valid items (i.e., if it is an empty array), joining an empty string with '、' will result in an empty array rather than a single empty string ('、'), which could lead to unexpected behavior when using this value later on.
Here's how you can enhance the formats function to fix this:
const formats = computed(() => {
return file_type_list.value.length > 0 ? file_type_list.value.join('、') : '';
});This modification checks the length of file_type_list before joining its elements; if it's greater than zero, the function returns the joined string; otherwise, it returns an empty string instead. This ensures that even if file_type_list contains nothing, the resulting formats will be safely used without causing errors.
… upload files after adding them in lowercase letters (#4498)
fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters