Skip to content

fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters #4498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 11, 2025
Merged

fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters #4498

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/src/components/dynamics-form/items/upload/LocalFileUpload.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ const accept = computed(() => {
return (attrs.file_type_list || []).map((item: any) => '.' + item.toLowerCase()).join(',')
})
const file_type_list = computed(() => {
return attrs.file_type_list || []
return attrs.file_type_list.map((item: any) => item.toUpperCase()) || []
})
const formats = computed(() => {
return (attrs.file_type_list || []).map((item: any) => item.toUpperCase()).join('、')
return file_type_list.value.join('、')
})
const file_size_limit = computed(() => {
return attrs.file_size_limit || 50
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no obvious errors or optimizations in this code snippet. However, there is a potential issue with the formats calculation: if file_type_list does not contain any valid items (i.e., if it is an empty array), joining an empty string with '、' will result in an empty array rather than a single empty string ('、'), which could lead to unexpected behavior when using this value later on.

Here's how you can enhance the formats function to fix this:

const formats = computed(() => { 
  return file_type_list.value.length > 0 ? file_type_list.value.join('、') : '';  
});

This modification checks the length of file_type_list before joining its elements; if it's greater than zero, the function returns the joined string; otherwise, it returns an empty string instead. This ensures that even if file_type_list contains nothing, the resulting formats will be safely used without causing errors.

Expand Down
Loading