fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters

[shaohuzhang1]

fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code has a few minor issues that can be addressed to enhance its functionality:

1. Missing Type Hinting: Adding type hints to SystemEncoder can improve code readability and help with IDE support.
2. Removing Redundant Code: The line json_str = json_str.replace('\\u0000', '') is redundant since the default behavior of replace() does not remove empty strings ('\\u0000'). This can cause unnecessary processing.

Here's the updated code with these improvements:

from typing import Any

import uuid

class SystemEncoder(json.JSONEncoder):
    """Custom JSON encoder that removes null characters from the output."""
    
    def __init__(self) -> None:
        super().__init__()
    
    def encode(self, obj: Any) -> str:
        # Attempt to serialize the object using parent logic
        result = super().encode(obj)
        
        # Optionally, use replace('\\\\u0000', '') if 'empty string' replacement is needed,
        # but this should typically be handled by the base implementation
        
        return result
    
    def default(self, obj: Any) -> str | UUID:
        """
        Convert non-serializable types into serializable strings/UUIDs.
        """
        if isinstance(obj, uuid.UUID):
            return str(obj)

Explanation of Changes:

• Type Hints: Added Any for better type hinting, which indicates that the parameters and return values can be of any data type.
• Initialization Method: Introduced an explicit constructor method (__init__) for proper initialization, although it doesn't add significant functionality beyond what Python expects by default.
• Removed Redundant Line: Modified the line to handle cases where no additional replacements might be necessary. Note that handling empty strings ('') specifically may depend on specific use cases or configurations.

[shaohuzhang1]

The provided Python code snippet contains some minor improvements and corrections for better readability and functionality:

1. Remove Unnecessary Code: The line self.answer += str(e) can be removed since it is not used anywhere else in the function.

2. Simplify Update Command: The last update command after the finally block can be simplified to include just the state field, as you're already updating all fields when setting details.

Here's the revised code:

@@ -94,9 +93,6 @@ def hand_node_result(self, current_node, node_result_future):
        try:
            # ... (existing code)

            self.status = 500
            current_node.get_write_error_context(e)
-            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(
-                details=self.get_runtime_details(),
-                state=State.FAILURE)
 
        finally:
            current_node.node_chunk.end()
-            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(details=self.get_runtime_details(), state=State.FAILURE)
+            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(state=State.FAILURE)

Summary of Changes

• Removed the redundant line adding error message to self.answer.
• Simplified the final QuerySet.KnowledgeAction.update() call by excluding unnecessary parameters.