Skip to content

fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 11, 2025
Merged

fix: Manually adding file types to the workflow knowledge base cannot upload files after adding them in lowercase letters #4499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions apps/application/flow/knowledge_workflow_manage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,7 @@ def hand_node_result(self, current_node, node_result_future):
self.status = 500
current_node.get_write_error_context(e)
self.answer += str(e)
QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(
details=self.get_runtime_details(),
state=State.FAILURE)
QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(state=State.FAILURE)
finally:
current_node.node_chunk.end()
QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided Python code snippet contains some minor improvements and corrections for better readability and functionality:

  1. Remove Unnecessary Code: The line self.answer += str(e) can be removed since it is not used anywhere else in the function.

  2. Simplify Update Command: The last update command after the finally block can be simplified to include just the state field, as you're already updating all fields when setting details.

Here's the revised code:

@@ -94,9 +93,6 @@ def hand_node_result(self, current_node, node_result_future):
        try:
            # ... (existing code)

            self.status = 500
            current_node.get_write_error_context(e)
-            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(
-                details=self.get_runtime_details(),
-                state=State.FAILURE)
 
        finally:
            current_node.node_chunk.end()
-            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(details=self.get_runtime_details(), state=State.FAILURE)
+            QuerySet(KnowledgeAction).filter(id=self.params.get('knowledge_action_id')).update(state=State.FAILURE)

Summary of Changes

  • Removed the redundant line adding error message to self.answer.
  • Simplified the final QuerySet.KnowledgeAction.update() call by excluding unnecessary parameters.

Expand Down
7 changes: 7 additions & 0 deletions apps/common/encoder/encoder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,13 @@


class SystemEncoder(json.JSONEncoder):
def encode(self, obj):
# 先序列化为字符串
json_str = super().encode(obj)
# 移除所有空字符
json_str = json_str.replace('\\u0000', '')
return json_str

def default(self, obj):
if isinstance(obj, uuid.UUID):
return str(obj)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has a few minor issues that can be addressed to enhance its functionality:

  1. Missing Type Hinting: Adding type hints to SystemEncoder can improve code readability and help with IDE support.
  2. Removing Redundant Code: The line json_str = json_str.replace('\\u0000', '') is redundant since the default behavior of replace() does not remove empty strings ('\\u0000'). This can cause unnecessary processing.

Here's the updated code with these improvements:

from typing import Any

import uuid

class SystemEncoder(json.JSONEncoder):
    """Custom JSON encoder that removes null characters from the output."""
    
    def __init__(self) -> None:
        super().__init__()
    
    def encode(self, obj: Any) -> str:
        # Attempt to serialize the object using parent logic
        result = super().encode(obj)
        
        # Optionally, use replace('\\\\u0000', '') if 'empty string' replacement is needed,
        # but this should typically be handled by the base implementation
        
        return result
    
    def default(self, obj: Any) -> str | UUID:
        """
        Convert non-serializable types into serializable strings/UUIDs.
        """
        if isinstance(obj, uuid.UUID):
            return str(obj)

Explanation of Changes:

  • Type Hints: Added Any for better type hinting, which indicates that the parameters and return values can be of any data type.
  • Initialization Method: Introduced an explicit constructor method (__init__) for proper initialization, although it doesn't add significant functionality beyond what Python expects by default.
  • Removed Redundant Line: Modified the line to handle cases where no additional replacements might be necessary. Note that handling empty strings ('') specifically may depend on specific use cases or configurations.

Expand Down
Loading