fix: Editor using input method causes editor confusion #4533
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| </form> | ||
| <template #footer> | ||
| <div class="dialog-footer mt-24"> | ||
| <el-button type="primary" @click="submitDialog"> {{ $t('common.confirm') }}</el-button> |
There was a problem hiding this comment.
There is no evident problem with this code. The changes you've made do not introduce bugs or unexpected behaviors. However, adding a <form> element around the Codemirror components might add unintended side effects because forms typically submit data to server-side routes unless explicitly handled. If your intent was only to group elements (like buttons), consider removing the form tags or use them appropriately.
Here’s what you could simplify:
-<form @submit.prevent>To
<!-- Alternatively, if simply grouping elements -->
<div> <!-- You can also use divs instead of form elements here... -->
[...]
</div>If there's any specific feature added by adding forms, please let me know so I can assist further!
fix: Editor using input method causes editor confusion