Skip to content

fix: Editor using input method causes editor confusion #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 17, 2025
+25 −22
Merged

fix: Editor using input method causes editor confusion #4533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 25 additions & 22 deletions ui/src/components/codemirror-editor/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,34 +1,37 @@
<template>
<div class="codemirror-editor w-full">
<Codemirror
v-model="data"
ref="cmRef"
:extensions="extensions"
:style="codemirrorStyle"
:tab-size="4"
:autofocus="true"
v-bind="$attrs"
/>

<form @submit.prevent>
<Codemirror
v-model="data"
ref="cmRef"
:extensions="extensions"
:style="codemirrorStyle"
:tab-size="4"
:autofocus="true"
v-bind="$attrs"
/>
</form>
<div class="codemirror-editor__footer">
<el-button text type="info" @click="openCodemirrorDialog" class="magnify">
<AppIcon iconName="app-magnify" style="font-size: 16px"></AppIcon>
</el-button>
</div>
<!-- Codemirror 弹出层 -->
<el-dialog v-model="dialogVisible" :title="title" append-to-body fullscreen>
<Codemirror
v-model="cloneContent"
:extensions="extensions"
:style="codemirrorStyle"
:tab-size="4"
:autofocus="true"
style="
height: calc(100vh - 160px) !important;
border: 1px solid #bbbfc4;
border-radius: 4px;
"
/>
<form @submit.prevent>
<Codemirror
v-model="cloneContent"
:extensions="extensions"
:style="codemirrorStyle"
:tab-size="4"
:autofocus="true"
style="
height: calc(100vh - 160px) !important;
border: 1px solid #bbbfc4;
border-radius: 4px;
"
/>
</form>
<template #footer>
<div class="dialog-footer mt-24">
<el-button type="primary" @click="submitDialog"> {{ $t('common.confirm') }}</el-button>
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no evident problem with this code. The changes you've made do not introduce bugs or unexpected behaviors. However, adding a <form> element around the Codemirror components might add unintended side effects because forms typically submit data to server-side routes unless explicitly handled. If your intent was only to group elements (like buttons), consider removing the form tags or use them appropriately.

Here’s what you could simplify:

-<form @submit.prevent>

To

<!-- Alternatively, if simply grouping elements -->
<div> <!-- You can also use divs instead of form elements here... -->   
  [...]
</div>

If there's any specific feature added by adding forms, please let me know so I can assist further!

Expand Down
Loading