Skip to content

fix: Support embedding multiple Applications#1866

Merged
liuruibin merged 1 commit intomainfrom
pr@mian@fix_support_s
Dec 18, 2024
Merged

fix: Support embedding multiple Applications#1866
liuruibin merged 1 commit intomainfrom
pr@mian@fix_support_s

Conversation

@liuruibin
Copy link
Member

Closes #1659

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 18, 2024

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liuruibin liuruibin force-pushed the pr@mian@fix_support_s branch from aeec494 to 75b0bb1 Compare December 18, 2024 02:55
@liuruibin liuruibin force-pushed the pr@mian@fix_support_s branch from 75b0bb1 to f150778 Compare December 18, 2024 04:13
@liuruibin liuruibin merged commit bdea68c into main Dec 18, 2024
4 checks passed
@liuruibin liuruibin deleted the pr@mian@fix_support_s branch December 18, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]动态注入第三方script资源时,存在重复添加maxkb标签问题

2 participants

Comments