fix: The functions in the library cannot be modified after being defined

[shaohuzhang1]

fix: The functions in the library cannot be modified after being defined

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The provided code snippet has some minor optimizations and corrections that can be suggested:

1. Variable Naming Consistency: The variable to_end_column is unnecessarily defined before use, which could be removed.

2. Condition Simplification: The condition in the return statement of getRangeFromLineAndColumn can be simplified using logical AND (&&) instead of multiple comparison checks.

Here's an optimized version of the function:

function getRangeFromLineAndColumn(state: any, line: number, column: number, end_column?: number): { form: number, to: number } {
  const l = state.doc.line(line);
  const form = l.from + column;
  
  let rangeTo =
    end_column !== undefined && end_column < l.to ?
      l.from + end_column :
      l.to;

  return {
    form: form > l.to ? l.to : form,
    to: rangeTo
  };
}

These changes reduce redundancy and improve readability while maintaining correct functionality.