Skip to content

fix: Model editing prohibits modifying model types #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 30, 2024
Merged

fix: Model editing prohibits modifying model types #1944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/views/template/component/EditModel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
<span>模型类型</span>
</template>
<el-select
disabled
v-loading="model_type_loading"
@change="list_base_model($event, true)"
v-model="base_form_data.model_type"
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The disabled attribute on the <el-select> element is set incorrectly. It should be outside of the template but within the component's script section or directly above the v-model. Adjust it to:
props: {
  base_form_data: Object,
},
created() {

}, methods: {
...

Then update the HTML as follows:

<template>
  <!-- ... -->
  <el-select :disabled="true" v-loading="model_type_loading">
    ...
  </el-select>
</template>

Optimization Suggestion: Consider using computed properties instead of local data bindings wherever possible to improve performance and readability.

Summary of Changes:

  1. Correct Placement of disabled:

    • Ensure that the disabled property is defined correctly in the parent/component scope (data, computed, methods) where the Vue instance lives.

  2. Computation Property Usage:

    • Use computed properties if you have multiple places in your code where this value remains constant or updates regularly.

Feel free to ask if you need further clarification on these changes!

Expand Down