Skip to content

fix: Embedded application displays incomplete data #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Dec 31, 2024
Merged

fix: Embedded application displays incomplete data #1954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/application/flow/step_node/application_node/impl/base_application_node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def get_answer_list(self) -> List[Answer] | None:
if self.answer_text is None:
return None
application_node_dict = self.context.get('application_node_dict')
if application_node_dict is None:
if application_node_dict is None or len(application_node_dict) == 0:
return [
Answer(self.answer_text, self.view_type, self.runtime_node_id, self.workflow_params['chat_record_id'],
self.context.get('child_node'))]
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Dec 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good overall. Here's a summary of what was checked:

  1. Conditional Check: The if condition checks for both the presence and non-zero length of application_node_dict. This ensures that even an empty dictionary returns all answers, which might be appropriate in some contexts.

  2. Simplification: Removing spaces around brackets makes the code slightly cleaner but does not affect functionality.

  3. Return Statement: The function still correctly returns a list with one Answer object unless application_node_dict is absent.

The code should work well as is and can handle the situation where application_node_dict could be either null or have zero entries without introducing any bugs. If there are further optimizations needed, additional context about the specific use case would be helpful to identify potential areas for improvement.

Expand Down
Loading