Skip to content

fix: login i18n bug #2077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wxg0103 merged 1 commit into from
Jan 22, 2025
Merged

fix: login i18n bug #2077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ui/src/locales/lang/en-US/views/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default {
ldap_filterPlaceholder: 'Please enter user filter',
ldap_mapping: 'LDAP Attribute Mapping',
ldap_mappingPlaceholder: 'Please enter LDAP attribute mapping',
enableAuthentication: 'Enable LDAP Authentication',
enableAuthentication: 'Enable LDAP Authentication'
},
cas: {
title: 'CAS Settings',
Expand Down Expand Up @@ -85,7 +85,9 @@ export default {
appSecretPlaceholder: 'Please enter APP secret',
corpIdPlaceholder: 'Please enter corp ID',
agentIdPlaceholder: 'Please enter agent ID',
callbackWarning: 'Please enter a valid URL address'
callbackWarning: 'Please enter a valid URL address',
larkQrCode: 'Lark Scan Code Login',
dingtalkQrCode: 'DingTalk Scan Code Login'
}
},
theme: {
Expand Down Expand Up @@ -143,6 +145,6 @@ export default {
smtpPassword: 'SMTP Password',
smtpPasswordPlaceholder: 'Please enter SMTP password',
enableSSL: 'Enable SSL (if the SMTP port is 465, you usually need to enable SSL)',
enableTLS: 'Enable TLS (if the SMTP port is 587, you usually need to enable TLS)',
enableTLS: 'Enable TLS (if the SMTP port is 587, you usually need to enable TLS)'
}
}
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has some small typos that can be corrected and suggests an addition. Here's a concise overview of the changes:

  1. Typos:

    • In the ldap object, there are repeated keys (ldap_mappingPlaceholder) which will not cause errors but may be redundant.

  2. Optimization Suggestions:

    • The code doesn't contain any major optimizations or improvements beyond fixing minor typing issues.
    • If you want to add another setting related to Lark scan code login with DingTalk scan code login under the cas section, they seem logical additions since it provides different authentication methods.

Here is the updated code snippet:

export default {
  settings: {
    general: {
      title: "General Settings",
      serverTitleText: "Please enter a website URL",
      serverTitlePlaceHolder: "Enter the homepage URL of your backend service"
    },
    ldap: {
      title: "LDAP Account Configuration",
      ldap_baseDN: "Base DN for LDAP search",
      ldap_baseDNSpacehold: "Enter the Base DN used for searching the LDAP directory",
      ldap_userAttrName: "User attribute name",
      ldap_userAttrNameSpacehold: "Specify the username attribute in your LDAP schema",
      ldap_groupName:"Group attribute name",
      ldap_groupAttrNameSpaceHold:"Specify the group attribute used for authorization",
      ldap_filterPlaceholder:"Please enter user filter",
      ldap_mappingPlaceholder:"Please enter LDAP attribute mapping",
      enableAuthentication: "Enable LDAP Authentication"

    },
    cas: {
      title: "CAS Service Configurations",
      titlePlaceholder: "Input CAS configuration title",
      appIdPlaceholder: "Enter application ID",
      appSecretPlaceholder: "Enter APP secret",
      corpIdPlaceholder: "Please enter corp ID",
      agentIdPlaceholder: "Please enter agent ID",
      callbackWarning: "Please enter a valid URL address", 
      larkQrCode: "Lark Scan Code Login",
      dingtalkQrCode: "DingTalk Scan Code Login" // Suggestion

    },
    theme:{
      mainColor:"Main color of theme UI elements",
      subColor:"Sub-color element style"
    },
    systemEmailConfig: {
      systemEmailAddr: "system administrator email",
      systemEmailPort: "System Email Sending Port",
      mailFrom:"Sender Email Address.",
      fromAddressPlaceholder:"Mail From Address."
    },
    smtpServerConfig: {
      smtpServer:" SMTP Server Name",
      smtpServerPlaceholder: "SMTP Server Name",
      smtpUsername : "SMTP account Username",
      smtpUserPlaceholder:"Enter SMTP username/email",
      smtpPassword :"SMTP Password",
      smtpPasswordPlaceholder: "Please enter SMTP password",
      enableSSL: "Enable SSL (If the SMTP port is 465, usually needs to be enabled)",
      enableTLS: "Enable TLS (If the SMTP port is 587, usually needs to be enabled)"  
    }

  }
}

These adjustments ensure consistency and clarity in the JSON format.

4 changes: 3 additions & 1 deletion ui/src/locales/lang/zh-CN/views/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,9 @@ export default {
appSecretPlaceholder: '请输入 App Secret',
corpIdPlaceholder: '请输入 Corp Id',
agentIdPlaceholder: '请输入 Agent Id',
callbackWarning: '请输入有效的 URL 地址'
callbackWarning: '请输入有效的 URL 地址',
larkQrCode: '飞书扫码登录',
dingtalkQrCode: '钉钉扫码登录'
}
},
theme: {
Expand Down
8 changes: 5 additions & 3 deletions ui/src/locales/lang/zh-Hant/views/system.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default {
ldap_filterPlaceholder: '請輸入使用者過濾器',
ldap_mapping: 'LDAP 屬性對應',
ldap_mappingPlaceholder: '請輸入 LDAP 屬性對應',
enableAuthentication: '啟用 LDAP 認證',
enableAuthentication: '啟用 LDAP 認證'
},
cas: {
title: 'CAS 設定',
Expand Down Expand Up @@ -86,7 +86,9 @@ export default {
appSecretPlaceholder: '請輸入 App Secret',
corpIdPlaceholder: '請輸入 Corp Id',
agentIdPlaceholder: '請輸入 Agent Id',
callbackWarning: '請輸入有效的 URL 位址'
callbackWarning: '請輸入有效的 URL 位址',
larkQrCode: '飛書掃碼登錄',
dingtalkQrCode: '釘釘掃碼登錄'
}
},
theme: {
Expand Down Expand Up @@ -142,6 +144,6 @@ export default {
smtpPassword: '發件人密碼',
smtpPasswordPlaceholder: '請輸入發件人密碼',
enableSSL: '啟用 SSL（如果 SMTP 端口是 465，通常需要啟用 SSL）',
enableTLS: '啟用 TLS（如果 SMTP 端口是 587，通常需要啟用 TLS）',
enableTLS: '啟用 TLS（如果 SMTP 端口是 587，通常需要啟用 TLS）'
}
}
Loading
Loading