fix: i18n azure llm mode

[shaohuzhang1]

fix: i18n azure llm mode

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

The code snippet appears to be written using Python with some string localization conventions that differ from modern practices. Here are the minor adjustments and points of improvement I would suggest:

1. String Localization: The use of gettext function is good practice, but it's recommended to use context managers like with gettext.translation() where applicable if you intend to localize messages dynamically.

2. Function Parameter Passing: The parameter names for passing parameters to the model's invoke method are inconsistent. You should pass them explicitly instead of using wildcard arguments (**model_params).

Here’s an improved version of your code incorporating these suggestions:

try:
    model = provider.get_model(model_type, model_name, model_credential, content=gettext('Hello'))
except (Exception, AppApiException) as e:
    raise e

This change ensures clarity in how parameters are passed to the model's invoke method and adheres to best practices related to string handling.

[shaohuzhang1]

There are no irregularities or major issues with this code snippet based on the provided context.

One minor suggestion is to use f-string formatting within gettext instead of concatenation:

content=f'{{{gettext("Hello")}}}'

This can improve readability.

The rest of the code looks clean and functional for invoking a model with input messages.

[shaohuzhang1]

The code appears to be using both Python's built-in gettext function from the gettext module and Flask's current_app._translate. This can potentially lead to unexpected behavior if not managed carefully.

Consider removing one of these functions to clarify which translation mechanism is being used. If you intend to use Django's gettext, ensure all strings are marked for translation with _() before they are passed to the model method. Here's an optimized version that uses only one source:

@@ -53,11 +53,10 @@ def is_valid(self, model_type: str, model_name, model_credential: Dict[str, obje
                     return False
         try:
-            if model.type == 'flask':
-                content = current_app._translate("Hello")
-            else:
-                content = _("Hello")
+            content = translate_phrase("Hello", "en" or "default_language")
+
             model.invoke([HumanMessage(content=content)])
         except AppApiException as e:
             raise e

Make sure to implement a helper function like translate_phrase that fetches the appropriate translated phrase based on your needs (e.g., fetching translations from a database or an external API).