Skip to content

Comments

feat: Supports specified user input title(#2288)#2313

Merged
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/workflow-base-node
Feb 18, 2025
Merged

feat: Supports specified user input title(#2288)#2313
wangdan-fit2cloud merged 1 commit intomainfrom
pr@main/workflow-base-node

Conversation

@wangdan-fit2cloud
Copy link
Contributor

What this PR does / why we need it?

Summary of your change

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.

@wangdan-fit2cloud wangdan-fit2cloud merged commit ff3dec2 into main Feb 18, 2025
4 checks passed
@wangdan-fit2cloud wangdan-fit2cloud deleted the pr@main/workflow-base-node branch February 18, 2025 07:03
<UserInputTitleDialog ref="UserInputTitleDialogRef" @refresh="refreshFieldTitle" />
</template>

<script setup lang="ts">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code looks mostly correct, but there's a small discrepancy: you've added an el-button with the label "common.add" between the two existing buttons. Instead of using the <span> element to wrap around it, I recommend keeping all elements within the same structure for better semantic integrity.

There are no significant irregularities or potential issues in this code snippet. However, here's the adjusted version:

<div class="flex-between mb-16">
  <h5 class="lighter">{{ $t('chat.userInput') }}</h5>
  <div>
    <el-button type="primary" link @click="openChangeTitleDialog">
      <el-icon>
        <Setting />
      </el-icon>
    </el-button>
    <el-button type="primary" link @click="openAddDialog()">
      <el-icon :class="{ 'mr-4': true }">
        <Plus />
      </el-icon>
      {{ $t('common.add') }}
    </el-button>
  </div>
</div>

This ensures that all buttons have appropriate spacing when the content is rendered in different contexts.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 18, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants