feat: The demonstration page supports modifying dialogue summaries #2348
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -90,5 +90,6 @@ export default { | |
| title: '知識庫引用', | ||
| question: '用戶問題', | ||
| optimizationQuestion: '優化後問題' | ||
| }, | ||
| editTitle: '編輯標題', | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| <template> | ||
| <el-dialog | ||
| :title="$t('chat.editTitle')" | ||
| v-model="dialogVisible" | ||
| :close-on-click-modal="false" | ||
| :close-on-press-escape="false" | ||
| :destroy-on-close="true" | ||
| append-to-body | ||
| > | ||
| <el-form | ||
| label-position="top" | ||
| ref="fieldFormRef" | ||
| :model="form" | ||
| require-asterisk-position="right" | ||
| > | ||
| <el-form-item | ||
| prop="abstract" | ||
| :rules="[ | ||
| { | ||
| required: true, | ||
| message: $t('common.inputPlaceholder'), | ||
| trigger: 'blur' | ||
| } | ||
| ]" | ||
| > | ||
| <el-input | ||
| v-model="form.abstract" | ||
| maxlength="1024" | ||
| show-word-limit | ||
| @blur="form.abstract = form.abstract.trim()" | ||
| /> | ||
| </el-form-item> | ||
| </el-form> | ||
| <template #footer> | ||
| <span class="dialog-footer"> | ||
| <el-button @click.prevent="dialogVisible = false"> {{ $t('common.cancel') }} </el-button> | ||
| <el-button type="primary" @click="submit(fieldFormRef)" :loading="loading"> | ||
| {{ $t('common.save') }} | ||
| </el-button> | ||
| </span> | ||
| </template> | ||
| </el-dialog> | ||
| </template> | ||
| <script setup lang="ts"> | ||
| import { reactive, ref, watch } from 'vue' | ||
| import type { FormInstance } from 'element-plus' | ||
| import useStore from '@/stores' | ||
| import { t } from '@/locales' | ||
| const { log } = useStore() | ||
| const emit = defineEmits(['refresh']) | ||
| const fieldFormRef = ref() | ||
| const loading = ref<boolean>(false) | ||
| const applicationId = ref<string>('') | ||
| const chatId = ref<string>('') | ||
| const form = ref<any>({ | ||
| abstract: '' | ||
| }) | ||
| const dialogVisible = ref<boolean>(false) | ||
| const open = (row: any, id: string) => { | ||
| applicationId.value = id | ||
| chatId.value = row.id | ||
| form.value.abstract = row.abstract | ||
| dialogVisible.value = true | ||
| } | ||
| const submit = async (formEl: FormInstance | undefined) => { | ||
| if (!formEl) return | ||
| await formEl.validate((valid) => { | ||
| if (valid) { | ||
| log.asyncPutChatClientLog(applicationId.value, chatId.value, form.value, loading).then(() => { | ||
| emit('refresh') | ||
| dialogVisible.value = false | ||
| }) | ||
| } | ||
| }) | ||
| } | ||
| defineExpose({ open, close }) | ||
| </script> | ||
| <style lang="scss" scoped></style> | ||
|
Contributor
Author
There was a problem hiding this comment. The provided code is syntactically correct and should work as intended with Element Plus components. There are a few minor improvements you might consider:
Here's a slightly refined version of the code incorporating these considerations: @@ -0,0 +1,85 @@
+<template>
+ <el-dialog
+ :title="$t('chat.editTitle')"
+ v-model="dialogVisible"
+ :close-on-click-modal="false"
+ :close-on-press-escape="false"
+ :destroy-on-close="true"
+ append-to-body
+ >
+ <el-form
+ label-position="top"
+ ref="fieldFormRef"
+ :model="form"
+ require-asterisk-position="right"
+ >
+ <el-form-item
+ prop="abstract"
+ :rules="[
+ {
+ required: true,
+ message: $t('common.inputPlaceholder'),
+ trigger: 'blur'
+ }
+ ]"
+ >
+ <el-input
+ v-model="form.abstract"
+ maxlength="1024"
+ show-word-limit
+ @blur="form.abstract = form.abstract.trim()"
+ />
+ </el-form-item>
+ </el-form>
+ <template #footer>
+ <span class="dialog-footer">
+ <el-button @click.prevent="dialogVisible = false"> {{ $t('common.cancel') }} </el-button>
+ <el-button type="primary" @click="submit(fieldFormRef)" :loading="loading">
+ {{ $t('common.save') }}
+ </el-button>
+ </span>
+ </template>
+ </el-dialog>
+</template>
<script setup lang="ts">
import { reactive, ref, watch } from 'vue';
import type { FormInstance } from 'element-plus';
import useStore from '@/stores';
import { t } from '@/locales';
const store = useStore() // Specify the actual type of your store
const emit = defineEmits(['refresh']);
const fieldFormRef = ref<FormInstance>();
const loading = ref(false);
const applicationId = ref('');
const chatId = ref('');
const form = ref<{ abstract: string }>({
abstract: ''
});
const dialogVisible = ref(false);
const open = (row: any, id: string) => {
applicationId.value = id;
chatId.value = row.id;
form.value.abstract = row.abstract;
dialogVisible.value = true;
};
const submit = async (formEl: FormInstance | undefined) => {
if (!formEl) return;
try {
await formEl.validate();
await store.asyncPutChatClientLog(applicationId.value, chatId.value, form.value, loading.value);
emit('refresh');
dialogVisible.value = false;
} catch (error) {
console.error(error); // Log error in development environment
}
};
defineExpose({ open });
</script>
<style lang="scss" scoped></style>Ensure that all imports and dependencies are correctly installed and available in your project. This revised code provides type safety and basic accessibility improvements while maintaining functional correctness.
Contributor
Author
There was a problem hiding this comment. The code appears to be a Vue component implementing an edit form for chat messages using Element Plus components. Here are some points and potential improvements: Potential Issues and Improvements:
Here's a simplified version with additional type definitions and some logging for errors during the save operation: <script setup lang="ts">
import { ref, watchEffect } from 'vue';
import type { FormInstance } from 'element-plus';
import useStore from '@/stores';
import { t } from '@/locales';
const { log } = useStore();
const emit = defineEmits(['refresh']);
const fieldFormRef = ref<FormInstance>();
const loading = ref(false);
const applicationId = ref('');
const chatId = ref('');
interface FormData {
abstract: string;
}
let formState: formData | null = null;
const form = ref({
abstract: ''
});
const dialogVisible = ref<boolean>(false);
// Initialize state data when opening the dialog
const updateFormData = (row: any, id: string) => {
applicationId.value = id;
chatId.value = row.id;
form.value.abstract = row.abstract;
};
const open = (rowData: any, id: string): void => {
// Fetch and load initial data before showing the dialog
Promise.resolve().then(() => {
updateFormData(rowData, id);
dialogVisible.value = true;
}).catch(e => console.error("Failed to fetch data:", e));
};By addressing these areas, you'll create a more robust and maintainable component. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are some recommendations for optimizing and improving the code:
Class Naming Conventions: Consider using PascalCase or CamelCase for class names to make them more readable.
Serializer Structure Simplification: The
ChatSerializershas a nested serializer in itsOperateclass which adds unnecessary complexity. It might be better to have separate classes for different operations instead of nesting serializers.Error Handling Cleanup: Use consistent error handling throughout. Currently, it's okay but ensure that all exceptions raise the same type of exception.
Optimization in Logic Delete Method: The method can be optimized by directly accessing the database without filtering first, then updating based on conditions.
ReAbstract Instance Method:
.get()inside the loop if you're using Python 3.7+, as dictionaries maintain insertion order.Add a check before attempting to update the abstract field to ensure there is an abstract value to overwrite.
General Formatting: Ensure consistent formatting including spacing between statements, variable definitions, etc., this improves readability.
Example refactored version:
This version consolidates similar functionalities under separate methods and ensures cleaner, more efficient execution of each operation.