Skip to content

fix: Fix add function lib error#2393

Merged
liuruibin merged 1 commit intomainfrom
pr@main@fix_add_lib
Feb 25, 2025
Merged

fix: Fix add function lib error#2393
liuruibin merged 1 commit intomainfrom
pr@main@fix_add_lib

Conversation

@shaohuzhang1
Copy link
Contributor

fix: Fix add function lib error --bug=1052403 --user=刘瑞斌 【函数库】-创建函数失败 https://www.tapd.cn/57709429/s/1658691 --bug=1052404 --user=刘瑞斌 【函数库】新建函数,无法添加参数 https://www.tapd.cn/57709429/s/1658693

--bug=1052403 --user=刘瑞斌 【函数库】-创建函数失败 https://www.tapd.cn/57709429/s/1658691

--bug=1052404 --user=刘瑞斌 【函数库】新建函数,无法添加参数 https://www.tapd.cn/57709429/s/1658693
@liuruibin liuruibin merged commit 9dbbe26 into main Feb 25, 2025
4 checks passed
@liuruibin liuruibin deleted the pr@main@fix_add_lib branch February 25, 2025 07:46
<div class="card-add-button flex align-center cursor p-8" @click="openCreateDialog()">
<AppIcon iconName="app-add-application" class="mr-8"></AppIcon>
{{ $t('views.functionLib.createFunction') }}
</div>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code appears to be mostly correct with no significant issues. Here's a few minor improvements you might want to consider:

  1. Parentheses: It’s generally better practice to add parentheses after function calls in Vue.js, even if they are empty parentheses (). This improves readability and prevents accidental misinterpretation.

  2. Spacing: Ensure consistent spacing around the colon (:) and equals sign (=) for cleaner syntax.

Here is the revised version of your code snippet with these changes applied:

<template>
  <el-row :gutter="15">
    <el-col :xs="24" :sm="12" :md="8" :lg="6" :xl="6" class="mb-16">
      <el-card shadow="hover" class="application-card-add" style="--el-card-padding: 8px">
        <div class="card-add-button flex align-center cursor p-8" @click="openCreateDialog()">
          <AppIcon iconName="app-add-application" class="mr-8"></AppIcon>
          {{ $t('views.functionLib.createFunction') }}
        </div>
      </el-card>
    </el-col>
  </el-row>
</template>

<script>
export default {
  methods: {
    openCreateDialog() {
      // Implementation details here
    }
  }
}
</script>

<style scoped>
/* Add styles as needed */
</style>

In summary, ensure that parenthetical notation (() when calling functions) and proper spacing are used consistently throughout your template, which maintains clean and readable code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants