Skip to content

fix: Fix variable-assign-node cannot publish #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liuruibin merged 1 commit into from
Feb 26, 2025
Merged

fix: Fix variable-assign-node cannot publish #2418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ui/src/workflow/nodes/variable-assign-node/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,11 +209,14 @@ const nodeCascaderRef = ref()
const nodeCascaderRef2 = ref()
const validate = async () => {
// console.log(replyNodeFormRef.value.validate())
return Promise.all([
let ps = [
replyNodeFormRef.value?.validate(),
...nodeCascaderRef.value.map((item: any) => item.validate()),
...nodeCascaderRef2.value.map((item: any) => item.validate())
]).catch((err: any) => {
...nodeCascaderRef.value.map((item: any) => item.validate())
]
if (nodeCascaderRef2.value) {
ps = [...ps, ...nodeCascaderRef.value.map((item: any) => item.validate())]
}
return Promise.all(ps).catch((err: any) => {
return Promise.reject({ node: props.nodeModel, errMessage: err })
})
}
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Feb 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is mostly correct, but there's an issue with the structure of the nodeCascaderRef2 mapping function when it might be undefined. It uses ...[] which can lead to unexpected behavior due to type widening if nodeCascaderRef2.value is not defined.

Here are some recommendations:

  1. Check for Undefined Value: Before attempting to map on nodeCascaderRef2, ensure that it exists. This prevents errors from occurring when calling .map() on an undefined value.

  2. Optimization: The current implementation will execute validate() calls serially instead of parallel for both replyNodeFormRef and each option in nodeCascaderRef. If you want to execute them in series, keep the existing Promise.all([...]).catch(). However, this ensures they are executed one after another without changing their order.

  3. Example Code:

const validate = async () => {
  let errorCount = 0;

  const allValidationsPromises = [
    replyNodeFormRef.value?.validate().then(() => {
      // Count validation success for replyNodeFormRef
      errorCount++;
    }).catch(err => {
      console.error('Validation failed:', err);
      errorCount++;
    }),

    ...nodeCascaderRef.value?.map(item => item.validate()).map(validateResult => {
      if (!validateResult.validated) { // Assuming each cascader node has a validated property indicating successful validation
        // Mark error for cascader nodes
        errorCount++;
      }
      return validateResult;
    }) || []

  ];

  await Promise.all(allValidationsPromises);

  if (errorCount === 0) {
    logger.info(`All validations passed.`);
  } else {
    throw new Error(`Failed to verify the form details: ${errorCount} errors found.`);
  }
};
  1. Error Handling: Ensure proper handling within catch() blocks. In the example above, if there are no validations failures (errorCount === 0) it logs a success message; otherwise, it throws an exception detailing how many checks failed.

These improvements help manage edge cases such as uninitialised references more gracefully, avoiding runtime TypeScript errors during evaluation.

Expand Down