Skip to content

feat: add operate log #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaohuzhang1 wants to merge 4 commits into from
Closed

feat: add operate log #2620

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
384e8f5
feat: Add Operate Log
XiaJunjie2020 Mar 18, 2025
ca95032
feat: Add Operate Log
XiaJunjie2020 Mar 18, 2025
4831468
Merge remote-tracking branch 'origin/main'
XiaJunjie2020 Mar 19, 2025
80ba749
feat: add operate log
XiaJunjie2020 Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/operate-log/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ function changeFilterHandle(val: string) {
function changeDayHandle(val: number | string) {
if (val !== 'other') {
daterange.value.start_time = beforeDay(val)
daterange.value.end_time = nowDate
daterange.value.end_time = ''
getList()
}
}
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks mostly correct but has a small issue. The nowDate variable is not defined in this snippet, so the line where it's assigned to daterange.value.end_time will result in an error.

To fix this:

  1. Define the nowDate Variable: Ensure that nowDate is properly initialized or imported before this code block executes, and contains a valid date value.
function nowDate() { return new Date(); }

Alternatively, ensure that there might be context around where nowDate is provided elsewhere in your application.

After making sure nowDate is correctly defined or accessible within your scope:

function changeFilterHandle(val: string) {
  // existing logic

}

function changeDayHandle(val: number | string) {
  if (val !== 'other') {
    daterange.value.start_time = beforeDay(val);
    daterange.value.end_time = ''; // Changed from nowDate to ''
    getList();
  }
}

If nowDate should actually represent new Date() at different times of execution, you may need additional logic to manage its state.

Expand Down