Skip to content

feat: add operate log #2623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XiaJunjie2020 merged 1 commit into from
Mar 19, 2025
Merged

feat: add operate log #2623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/views/operate-log/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ function changeFilterHandle(val: string) {
function changeDayHandle(val: number | string) {
if (val !== 'other') {
daterange.value.start_time = beforeDay(val)
daterange.value.end_time = nowDate
daterange.value.end_time = ''
getList()
}
}
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code is mostly correct, but there's one small issue that could be improved:

function changeDayHandle(val: number | string) {
  if (val !== 'other') {
    daterange.value.start_time = beforeDay(val);
    // Avoid an error when using `beforeDay` on 'other'
    daterange.value.end_time = typeof val === 'number' ? '' : nowDate;
    getList();
  }
}

Explanation of changes:

  1. Added a type check (typeof) to ensure that the value used in nowDate is a number before performing arithmetic with it, which prevents any errors. If val is not a number ('unknown'), the end time will remain unchanged instead of being set to undefined (undefined), which can lead to unintended behavior.

If you have more specific requirements or optimizations needed for this function, please clarify!

Expand Down