Skip to content

fix: The default suffix for workflow file upload nodes is set to uppercase DOC and PPT #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shaohuzhang1 wants to merge 1 commit into from
Closed

fix: The default suffix for workflow file upload nodes is set to uppercase DOC and PPT #3124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ui/src/workflow/nodes/base-node/component/FileUploadSettingDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<p class="line-height-22 mt-4">
{{ $t('common.fileUpload.document') }}
<el-text class="color-secondary"
>{{
>{{
$t(
'views.applicationWorkflow.nodes.baseNode.FileUploadSetting.fileUploadType.documentText'
)
Expand Down Expand Up @@ -86,7 +86,7 @@
<p class="line-height-22 mt-4">
{{ $t('common.fileUpload.image') }}
<el-text class="color-secondary"
>{{
>{{
$t(
'views.applicationWorkflow.nodes.baseNode.FileUploadSetting.fileUploadType.imageText'
)
Expand Down Expand Up @@ -114,7 +114,7 @@
<p class="line-height-22 mt-4">
{{ $t('common.fileUpload.audio') }}
<el-text class="color-secondary"
>{{
>{{
$t(
'views.applicationWorkflow.nodes.baseNode.FileUploadSetting.fileUploadType.audioText'
)
Expand All @@ -141,7 +141,7 @@
<p class="line-height-22 mt-4">
{{ $t('common.fileUpload.other') }}
<el-text class="color-secondary"
>{{
>{{
$t(
'views.applicationWorkflow.nodes.baseNode.FileUploadSetting.fileUploadType.otherText'
)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 May 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be two instances where there is an extra > character after $t() calls:

<el-text class="color-secondary">{{

Ensure that these should instead be:

<el-text class="color-secondary">{{ --}}

Additionally, it's a good practice to use single quotes around template literals to avoid syntax errors, especially when mixing inline and multi-line templates. Here’s how you can fix them:

Before:

'{{ $t('someKey', 'arg1 arg2') }}'

After replacing double/single quotes for consistency:

"$t('someKey', 'arg1 args2')"

Or using single quotes if prefered for clarity within the string itself:

'$t(\'someKey\', \'arg1 args2\')'

Expand Down