fix: The dropdown data of subsequent nodes in the form cannot be displayed back

[shaohuzhang1]

fix: The dropdown data of subsequent nodes in the form cannot be displayed back

[f2c-ci-robot]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[f2c-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[shaohuzhang1]

Here is a review of the provided code:

Issues:

1. Redundancy: The otherFields array is created but not used within the scope where it's defined, leading to potential memory wastage.
2. Simplification: Instead of mapping over form_field_list, you can use an arrow function directly. This reduces unnecessary steps.
3. Type Checking: The code assumes that all properties have a non-null .properties object with nested objects. Ensure this assumption holds true.

Optimizations:

1. Remove Unnecessary Variable Assignment: Since fields will be populated based on form_field_list, there’s no need to create otherFields.

Here's the revised code:

class FormNode extends AppNode {
  get_node_field_list() {
    const result = [];
    
    try {
      this.props.model.properties.node_data &&
      this.props.model.properties.node_data.form_field_list.length > 0 &&
      
      this.props.model.properties.node_data.form_field_list.forEach((item: any) => {
        // Check if the field already exists in fields
        if (!fields.includes(item.field)) {
          fields.push({
            value: item.field,
            label: typeof item.label == 'string' ? item.label : item.label.label
          });
        }
      });
      
    } catch (e) {}

    result.push({
      value: this.props.model.id,
      label: this.props.model.properties.stepName,
      type: this.props.model.type,
      children: fields || []
    });

    return result;
  }
}

This refactored version of your method should perform better and reduce memory usage without any functionality changes.