Skip to content

fix: The conversation page cannot be opened #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shaohuzhang1 merged 1 commit into from
Jul 29, 2025
Merged

fix: The conversation page cannot be opened #3770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/stores/modules/application.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import applicationApi from '@/api/application/application'
import { type Ref } from 'vue'
const useApplicationStore = defineStore('application', {
state: () => ({
location: `${window.location.origin}${window.MaxKB.chatPrefix}/`,
location: `${window.location.origin}${window.MaxKB.chatPrefix ? window.MaxKB.chatPrefix : window.MaxKB.prefix}/`,
}),
actions: {
async asyncGetApplicationDetail(id: string, loading?: Ref<boolean>) {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code appears to have some minor adjustments:

  1. Condition check in URL construction: The original code uses window.MaxKB.chatPrefix directly without checking if it exists before concatenating with the origin and prefix. This can lead to an error if chatPrefix is not defined.

  2. Parameter naming consistency: In the action method, you mentioned using a variable named id, but then used loading? Ref<boolean> which seems like TypeScript syntax for optionals, possibly intended to indicate whether a loading state is present.

Optimization Suggestion:

To improve robustness and maintainability, consider adding a default value to ensure that both chatPrefix and prefix are used if chatPrefix is indeed undefined. You could also extract this logic into a utility function or property if necessary.

Here's how you might structure the changes:

import appApi from '@/api/application/application'
import type { Ref } from 'vue'
const useApplicationStore = defineStore('application', {
   state: () => ({
     location: `${window.location.origin && window.MaxKB.chatPrefix}`
       ? `${window.location.origin}${window.MaxKB.chatPrefix}/`
       : `${window.location.origin}${window.MaxKB.prefix || ''}/`,
   }),
   actions: {
     async asyncGetApplicationDetail(id: string, loading?: Ref<boolean>) {
     // Your existing code here
     }
   },
})

By ensuring these checks and consolidations, your component should be more resilient and easier to understand.

Expand Down
Loading