Skip to content

feat: Support searching application conversation logs by user #3922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Aug 25, 2025
Merged

feat: Support searching application conversation logs by user #3922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ui/src/locales/lang/en-US/views/chat-log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export default {
},
table: {
abstract: 'Title',
username: 'User',
chat_record_count: 'Total Messages',
user: 'User',
feedback: {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some observations and improvements regarding your code:

  1. Duplicate Entries for user Field:

    • The field 'user' appears twice in the translation object (user: 'User', feedback: { ... }). It is recommended to ensure consistency by removing one of these entries.

  2. Potential Typographical Error in "Title" Translation:

    • While typically accurate, it's worth double-checking that all keys correspond correctly to their intended English counterparts unless there was an intentional typographical difference across languages.

  3. Consistency Check with Feedback Structure:

    • If you aim to have consistent properties within objects under the same key (e.g., both tables), consider whether each property should be consistently defined across different fields.

  4. Language Specifics:

    • Ensure that the translations are complete and appropriate according to the target language locale, especially if they differ significantly from English defaults.
export default {
  header: { title: 'Header Title', subtitle: 'Subheader Text' }
}

// Example usage in JSX:
const Header = ({ title, subtitle }) => (
  <div>
    <h1>{title}</h1>
    <p>{subtitle}</p>
  </div>
)

This refactored version maintains clarity and separates structure definition from use, which can improve readability and maintainability in larger applications.

Expand Down
1 change: 1 addition & 0 deletions ui/src/locales/lang/zh-CN/views/chat-log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export default {
},
table: {
abstract: '摘要',
username: '用户',
chat_record_count: '对话提问数',
user: '用户',
feedback: {
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet seems to be part of a configuration file for iView UI components, possibly related to displaying tables with specific properties like titles. Here’s a quick review:

Potential Issues and Suggestions

  1. Duplicate Property: The property { user: '用户' } appears twice within the table object. This might indicate an oversight or redundancy in the translation.

  2. Missing Keys:

    • Ensure that all necessary keys in translations (like username) have corresponding data available when rendered. This can prevent rendering errors during runtime.

  3. Performance Considerations:

    • If this data is frequently updated or dynamic, consider using a state management solution if it exists in your project (e.g., Vuex, React context).

  4. Code Style:

    • Maintain consistency in spacing around operator symbols (:).
    • Use proper indentation levels.

  5. Translation Key Consistency:

    • If you are dealing with localization where different languages use different characters for certain concepts (e.g., "username" vs. "Benutzername"), ensure these are consistently defined elsewhere in your app.

  6. Validation:

    • Consider adding validation or checks at build time to catch such inconsistencies early on before deployment.

Here's a slightly optimized version of the code without duplicating the same key:

export default {
  // other configurations...
  table: {
    abstract: '摘要',
    username: '用户', // Assuming a consistent naming convention here
    chat_record_count: '对话提问数'
  },
  feedback: { // ...other configurations may follow as needed }
};

By addressing these points, the code will be more robust and easier to maintain.

Expand Down
1 change: 1 addition & 0 deletions ui/src/locales/lang/zh-Hant/views/chat-log.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export default {
},
table: {
abstract: '摘要',
username: '用戶',
chat_record_count: '對話提問數',
user: '用戶',
feedback: {
Expand Down
38 changes: 29 additions & 9 deletions ui/src/views/chat-log/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,23 @@

<el-card style="--el-card-padding: 24px">
<div class="mb-16">
<el-select
v-model="query_option"
class="mr-12"
@change="search_type_change"
style="width: 75px"
>
<el-option :label="$t('views.chatLog.table.abstract')" value="abstract" />
<el-option :label="$t('views.chatLog.table.username')" value="username" />
</el-select>
<el-input
v-model="search"
@change="getList"
:placeholder="$t('common.search')"
prefix-icon="Search"
class="w-240 mr-12"
clearable
/>
<el-select
v-model="history_day"
class="mr-12"
Expand All @@ -29,14 +46,6 @@
style="width: 240px"
class="mr-12"
/>
<el-input
v-model="search"
@change="getList"
:placeholder="$t('common.search')"
prefix-icon="Search"
class="w-240"
clearable
/>
<div style="display: flex; align-items: center" class="float-right">
<el-button @click="dialogVisible = true" v-if="permissionPrecise.chat_log_clear(id)">
{{ $t('views.chatLog.buttons.clearStrategy') }}
Expand Down Expand Up @@ -256,6 +265,15 @@ const {
const emit = defineEmits(['refresh'])
const formRef = ref()

const search_form = ref<any>({
abstract: '',
username: '',
})

const search_type_change = () => {
search_form.value = {abstract: '', username: ''}
}

const dayOptions = [
{
value: 7,
Expand Down Expand Up @@ -308,6 +326,7 @@ const tableIndexMap = computed<Dict<number>>(() => {
.reduce((pre, next) => ({ ...pre, ...next }), {})
})
const history_day = ref<number | string>(7)
const query_option = ref<string>('abstract')

const search = ref('')
const detail = ref<any>(null)
Expand Down Expand Up @@ -416,7 +435,8 @@ function getList() {
...filter.value,
}
if (search.value) {
obj = { ...obj, abstract: search.value }
if (query_option.value === 'abstract'){obj = { ...obj, abstract: search.value }}
else if (query_option.value === 'username'){obj = { ...obj, username: search.value }}
}
return loadSharedApi({ type: 'chatLog', systemType: apiType.value })
.getChatLog(id as string, paginationConfig, obj, loading)
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a concise review of the provided code with suggestions for improvements:

Improvements:

  1. Single Instance of search_form: Ensure there is only one instance of search_form. Using it twice can lead to unexpected behavior. You should remove the second one.

  2. Optimize Function Calls: Consider using arrow functions where appropriate and avoiding unnecessary reassignments within loops if not necessary. This improves readability and performance.

  3. Consistent Spacing: Maintain consistent spacing around operators (=)` and ensure no trailing commas.

  4. Remove Redundant Comments & Spaces: Clean up unnecessary comments and spaces that do not add meaningful context.

  5. Use Template Literals Where Appropriate: Replace hardcoded strings with template literals for better consistency and readability.

  6. Simplify Logic for Query Option Change:

    • Modify the search_type_change method to reset the form accordingly instead of reassigning a constant value.

Suggestions:

// Step 1: Remove duplicate instances of search_form

const emit = defineEmits(['refresh']);
const formRef = ref();
const search = ref('');
const detail = ref<any>(null);
const filter = ref({});
const tableIndexMap = computed(() => {}); // Assuming this remains same
const history_day = ref(7);

const searchForm = ref({
  abstract: '',
  username: ''
});

// Step 2: Refactor search_type_change logic
const handleSearchOptionChange = () => {
  searchForm.value.abstract = '';
  searchForm.value.username = '';
};

// Step 3: Simplify search option handling outside getList
if (searchForm[queryOption].value.length > 0) {
  obj = { ...obj, [`${queryOption}Name`]: search };
}

// Updated getList function without redundant properties assignment
function getList() {
  const params = {
    userIdList: userInfos || [],
    systemType: apiType.value,
    pageSize: paginationConfig.pageSize,
    pageNum: paginationConfig.currentPage,
    statusSet: setStatus ? [...setStatus] : null as number[] | undefined,
    sortParamJsonStr: {},
    ...filter.value,
    ...{ [queryOption]: search.value }
  };

  return loadSharedApi({ type: 'chatLog', systemType: apiType.value })
    .getChatLog(id as string, paginationConfig, params, loading);
}

// Additional changes based on feedback:
// Keep the rest of the existing code clean and focused.

This set of improvements enhances maintainability, reduces redundancy, and optimizes certain parts of the code while maintaining clarity.

Expand Down
Loading