Skip to content

feat: Search application chat log by user #3923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Aug 25, 2025
Merged

feat: Search application chat log by user #3923

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/application/api/application_chat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,12 @@ def get_parameters():
type=OpenApiTypes.STR,
required=False,
),
OpenApiParameter(
name="username",
description="username",
type=OpenApiTypes.STR,
required=False,
),
OpenApiParameter(
name="min_star",
description=_("Minimum number of likes"),
Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code snippet appears to be from an OpenAPI schema definition used in web frameworks like FastAPI or Django REST Framework. Here's a quick review:

Irregularity/Suggestion #1: Redundant Field

  • The username field is described twice with the same parameters (type, etc.). This can be reduced.
@@ -65,7 +65,7 @@
         type=OpenApiTypes.STR,
         required=False,
     ),
-    OpenApiParameter(
-        name="username",
-        description="username",
+    OpenApiParameter(
         type=OpenApiTypes.INT,
         required=True,

Suggestion #2: Typographical Corrections

  • Corrected _ and " syntax errors. Replace _ with the appropriate import for translations (if needed), and ensure correct quotation marks.
import gettext
t = gettext.translation('messages', localedir='locales', languages=['en'])
_ = t.gettext

@@ -65,4 +65,4 @@
             required=True,
         )
     ],
)

Suggestion #3: Improved Documentation Quality

  • Enhance the comments and descriptions where possible to improve clarity.

    

    • 



@@ -65,9 +65,9 @@

type=OpenApiTypes.STR,  # Username parameter

required=False,

),

@@ -70,7 +70,8 @@

type=OpenApiTypes.INT,  # Minimum number of likes

required=True,

),

@@ -75,7 +76,7 @@

"required": [

@@ -82,9 +83,10 @@

]

}



These changes should help clean up the code and make it more readable. Please ensure they fit within your framework's documentation and context.


    

  
  




    


        

      
  
  

    
  
    
    

  

  

  



          

      
    








    


  









  


    


  		



  

    
          
            
          
          Expand Down
    
    
  



                
              


          


    

  



    
  

    

      

        


          

            
            
          


          



          
            5 changes: 5 additions & 0 deletions
          
          

        

  apps/application/serializers/application_chat.py

  
  
      
      
  





        
      


      

        











            


          

          

            
              

                
    

              

            
            
                            

                            


                              
   View file



                                    


                                  


                            


                            

                            

    Open in desktop



                
            
          

        

      

    



    



          

            




              
      
    
              

                
                  

                      Original file line number
                      Diff line number
                      Diff line change
                  

                
                
                      
      

    
          
            
          
          Expand Up
    
    @@ -51,6 +51,7 @@ class ApplicationChatRecordExportRequest(serializers.Serializer):
  


    

    

    

  
    class ApplicationChatQuerySerializers(serializers.Serializer):






    

    

    

  
        workspace_id = serializers.CharField(required=False, allow_null=True, allow_blank=True, label=_("Workspace ID"))






    

    

    

  
        abstract = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_("summary"))






    

    

    

  
        username = serializers.CharField(required=False, allow_blank=True, allow_null=True, label=_("username"))






    

    

    

  
        start_time = serializers.DateField(format='%Y-%m-%d', label=_("Start time"))






    

    

    

  
        end_time = serializers.DateField(format='%Y-%m-%d', label=_("End time"))






    

    

    

  
        application_id = serializers.UUIDField(required=True, label=_("Application ID"))






      

    
          
            
          
          Expand Down
          
            
          
          Expand Up
    
    @@ -86,6 +87,7 @@ def get_query_set(self, select_ids=None):
  


    

    

    

  
            query_set = QuerySet(model=get_dynamics_model(






    

    

    

  
                {'application_chat.application_id': models.CharField(),






    

    

    

  
                 'application_chat.abstract': models.CharField(),






    

    

    

  
                 'application_chat.asker': models.JSONField(),






    

    

    

  
                 "star_num": models.IntegerField(),






    

    

    

  
                 'trample_num': models.IntegerField(),






    

    

    

  
                 'comparer': models.CharField(),






      

    
        
          
        
        Expand All
    
    @@ -98,6 +100,9 @@ def get_query_set(self, select_ids=None):
  


    

    

    

  
                               }






    

    

    

  
            if 'abstract' in self.data and self.data.get('abstract') is not None:






    

    

    

  
                base_query_dict['application_chat.abstract__icontains'] = self.data.get('abstract')






    

    

    

  
            if 'username' in self.data and self.data.get('username') is not None:






    

    

    

  
                base_query_dict['application_chat.asker__username'] = self.data.get('username')






    

    

    

  
    







    

    

    

  
    







    

    

    

  
            if select_ids is not None and len(select_ids) > 0:






    

    

    

  
                base_query_dict['application_chat.id__in'] = select_ids






      


  
        

      
  
    
    

      
      
          



  

    

        

        

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Contributor


        

  Author


    

  


  

    

      
          @shaohuzhang1
      

      
            shaohuzhang1
  

      

      

      


        Aug 25, 2025


      
    


  




        

      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
Review and Optimizations


    

  1. 

    SQL Injection Risk: The current implementation of the get_query_set method uses string formatting directly to construct SQL queries from dictionary keys (application_chat.application_id, application_chat.abstract). This can lead to SQL injection vulnerabilities if untrusted data is used in these strings.
    

    2. 

  2. 

    Optimization:
    

      

    • Instead of creating a dynamic database manager with multiple columns, consider using filtering mechanisms provided by Django's ORM directly based on field names.
      • 

    • For better performance when querying large datasets, utilize pagination rather than loading all records into memory at once.
      • 

    

    3. 

  3. 

    Improvements:
    

      

    • Validate input fields thoroughly before constructing filters to ensure they match expected formats or types.
      • 

    • Consider adding default values or handling missing parameters more gracefully to prevent null errors during query execution.
      • 

    

    4. 



By addressing these points, you can enhance the security and efficiency of your application chat query serialization process.

    

  
  




    


        

      
  
  

    
  
    
    

  

  

  



          

      
    








    


  









  


    


  		



  

    
          
            
          
          Expand Down
    
    
  



                
              


          


    

  



  



    

  
  
    
      Loading