Skip to content

fix: import error #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhanweizhang7 merged 1 commit into from
Aug 25, 2025
Merged

fix: import error #3928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ui/src/components/resource-authorization-drawer/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@
</template>
<script setup lang="ts">
import { ref, onMounted, watch, computed, reactive } from 'vue'
import { permissionOptions } from '@/views/system/resource-authorization/constant'
import { getPermissionOptions } from '@/views/system/resource-authorization/constant'
import AuthorizationApi from '@/api/system/resource-authorization'
import { MsgSuccess, MsgConfirm } from '@/utils/message'
import { t } from '@/locales'
Expand All @@ -159,7 +159,9 @@ const { user } = useStore()
const props = defineProps<{
type: string
}>()

const permissionOptions = computed(() => {
return getPermissionOptions()
})
const drawerVisible = ref(false)
const multipleTableRef = ref()

Copy link
Contributor Author

@shaohuzhang1 shaohuzhang1 Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provided code has several areas that can be improved for clarity and maintainability. Here are some suggestions:

Improvements

  1. Function Name Consistency: The variable name permissionOptions is both imported and computed. It should either use one or the other consistently to avoid confusion.

  2. Use of Computed Property: Since you're already using a computed property, there's no need for an unnecessary function inside the computed block.

  3. Avoid Unnecessary Imports: Ensure you only import what you need.

  4. Code Formatting: Maintain consistent indentation and spacing throughout the file.

  5. Comments: Add comments where necessary to explain complex sections or decisions.

  6. Type Assertions: If typescript allows it, assert the specific types of variables to improve clarity.

  7. Remove Unused Variables: If type is not used anywhere, consider removing it.

Here’s the revised version with these improvements applied:

<template>
  <!-- template content -->
</template>

<script setup lang="ts">
// remove unused import
// import { permissionOptions } from '@/views/system/resource-authorization/constant'

import { useStore } from 'vuex';
import { computed } from 'vue';

import AuthorizationApi from '@/api/system/resource-authorization';
import { MsgSuccess, MsgConfirm } from '@/utils/message';
import { t } from '@/locales';

const { user } = useStore();

const props = defineProps<{ type: string }>();

// Use existing import instead of creating duplicate computed property
const permissionOptions = computed(() => {
  return fetchPermissionOptions(); // Example placeholder; replace with actual function call
});

const drawerVisible = ref(false);
const multipleTableRef = ref(null);

function fetchPermissionOptions(): any[] {
  return getPermissionOptions();
}
</script>

<style scoped>
/* styles */
</style>

Explanation of Changes

  • Removed the redundant import statement for the constant since we're already importing a computed property.
  • Used an alias (fetchPermissionOptions) for the function called within the computed expression to clarify its purpose.
  • Added a placeholder function fetchPermissionOptions to demonstrate replacing dynamic imports.
  • Simplified the syntax to ensure better readability and consistency.

Expand Down
Loading